Playlist support & TV Shuffle #986
Conversation
There was a problem hiding this comment.
This is Great! I used the playlist with mixed content and it worked flawlessly. It will be nice to have more features like, shuffle and random
The Shuffle and random buttons on on tv shows is a great addition! Also worked on my server with no bugs.
It would be nice if the shuffle and play random buttons were the same size.
|
@jkim2492 This will impact your work on the subtitles. The end goal is to unify all playback into the global queue functions. To make this work, I had to duplicate a lot of the video playback code and modify it to work with tasks. This PR addresses playlist support and shuffle tv seasons. I'm going to start applying it to the other video playback calls, but before I do, I need to copy over your new subtitle functions into the new video player. Before you continue work on the embeded subtitles, you may want to either wait until I finish this, or work on adding it here to begin with. |
|
@1hitsong I think waiting won't be a problem since I haven't decided on how to implement it yet :) |
| return true | ||
| end function | ||
|
|
||
| function CreateMovieDetailsGroup(movie) |
There was a problem hiding this comment.
im fixing the crashlog error for ShowScenes.brs and noticed the CreateMovieDetailsGroup function was duplicated here. can't we just include ShowScenes.brs to this task node?
Changes
Adds support for Playlists from the home view. Currently it only supports playback for videos and audio.
It also adds a Shuffle button to TV series and seasons as a demo of how we will eventually use global queue for all playback.
This PR is an MVP product, so it is NOT feature complete.
This is currently a WIP, so there will be bugs. Please post any findings as a comment.
Ignore how much code duplication there is. I had to convert a ton of stuff to tasks to make this work. Eventually, if approved, all playback will use this system and the old code will be removed.
Issues
Fixes #108 #198