Skip to content

Commit

Permalink
Merge pull request #472 from sparky8251/remove-wan-ddns
Browse files Browse the repository at this point in the history
Remove WAN domain name options
  • Loading branch information
joshuaboniface committed Sep 28, 2019
2 parents 6c22fab + 3f1fd61 commit 8c44662
Show file tree
Hide file tree
Showing 27 changed files with 8 additions and 59 deletions.
4 changes: 2 additions & 2 deletions src/bower_components/apiclient/connectionmanager.js
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ define(["events", "apiclient", "appStorage"], function(events, apiClientFactory,
}

function updateServerInfo(server, systemInfo) {
server.Name = systemInfo.ServerName, systemInfo.Id && (server.Id = systemInfo.Id), systemInfo.LocalAddress && (server.LocalAddress = systemInfo.LocalAddress), systemInfo.WanAddress && (server.RemoteAddress = systemInfo.WanAddress)
server.Name = systemInfo.ServerName, systemInfo.Id && (server.Id = systemInfo.Id), systemInfo.LocalAddress && (server.LocalAddress = systemInfo.LocalAddress)
}

function getEmbyServerUrl(baseUrl, handler) {
Expand Down Expand Up @@ -744,4 +744,4 @@ define(["events", "apiclient", "appStorage"], function(events, apiClientFactory,
}
}
}, ConnectionManager
});
});
12 changes: 3 additions & 9 deletions src/controllers/networking.js
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@ define(["loading", "libraryMenu", "globalize", "emby-checkbox", "emby-select"],
config.HttpsPortNumber = form.querySelector("#txtHttpsPort").value;
config.HttpServerPortNumber = form.querySelector("#txtPortNumber").value;
config.EnableUPnP = enableUpnp;
config.WanDdns = form.querySelector("#txtDdns").value;
config.BaseUrl = form.querySelector("#txtBaseUrl").value;
config.EnableRemoteAccess = form.querySelector("#chkRemoteAccess").checked;
config.CertificatePath = form.querySelector("#txtCertificatePath").value || null;
Expand Down Expand Up @@ -111,22 +110,17 @@ define(["loading", "libraryMenu", "globalize", "emby-checkbox", "emby-select"],
var selectHttpsMode = page.querySelector("#selectHttpsMode");
config.IsBehindProxy ? selectHttpsMode.value = "proxy" : config.RequireHttps ? selectHttpsMode.value = "required" : config.EnableHttps ? selectHttpsMode.value = "enabled" : selectHttpsMode.value = "disabled";
page.querySelector("#txtHttpsPort").value = config.HttpsPortNumber;
page.querySelector("#txtDdns").value = config.WanDdns || "";
page.querySelector("#txtBaseUrl").value = config.BaseUrl || "";
var txtCertificatePath = page.querySelector("#txtCertificatePath");
txtCertificatePath.value = config.CertificatePath || "";
page.querySelector("#txtCertPassword").value = config.CertificatePassword || "";
page.querySelector("#chkEnableUpnp").checked = config.EnableUPnP;
onCertPathChange.call(txtCertificatePath);
triggerChange(page.querySelector("#chkRemoteAccess"));
loading.hide();
}

function onCertPathChange() {
this.value ? view.querySelector("#txtDdns").setAttribute("required", "required") : view.querySelector("#txtDdns").removeAttribute("required")
}
view.querySelector("#chkRemoteAccess").addEventListener("change", function() {
this.checked ? (view.querySelector(".fldExternalAddressFilter").classList.remove("hide"), view.querySelector(".fldExternalAddressFilterMode").classList.remove("hide"), view.querySelector(".fldPublicPort").classList.remove("hide"), view.querySelector(".fldPublicHttpsPort").classList.remove("hide"), view.querySelector(".fldDdns").classList.remove("hide"), view.querySelector(".fldCertificatePath").classList.remove("hide"), view.querySelector(".fldCertPassword").classList.remove("hide"), view.querySelector(".fldHttpsMode").classList.remove("hide"), view.querySelector(".fldEnableUpnp").classList.remove("hide")) : (view.querySelector(".fldExternalAddressFilter").classList.add("hide"), view.querySelector(".fldExternalAddressFilterMode").classList.add("hide"), view.querySelector(".fldPublicPort").classList.add("hide"), view.querySelector(".fldPublicHttpsPort").classList.add("hide"), view.querySelector(".fldDdns").classList.add("hide"), view.querySelector(".fldCertificatePath").classList.add("hide"), view.querySelector(".fldCertPassword").classList.add("hide"), view.querySelector(".fldHttpsMode").classList.add("hide"), view.querySelector(".fldEnableUpnp").classList.add("hide"))
this.checked ? (view.querySelector(".fldExternalAddressFilter").classList.remove("hide"), view.querySelector(".fldExternalAddressFilterMode").classList.remove("hide"), view.querySelector(".fldPublicPort").classList.remove("hide"), view.querySelector(".fldPublicHttpsPort").classList.remove("hide"), view.querySelector(".fldCertificatePath").classList.remove("hide"), view.querySelector(".fldCertPassword").classList.remove("hide"), view.querySelector(".fldHttpsMode").classList.remove("hide"), view.querySelector(".fldEnableUpnp").classList.remove("hide")) : (view.querySelector(".fldExternalAddressFilter").classList.add("hide"), view.querySelector(".fldExternalAddressFilterMode").classList.add("hide"), view.querySelector(".fldPublicPort").classList.add("hide"), view.querySelector(".fldPublicHttpsPort").classList.add("hide"), view.querySelector(".fldCertificatePath").classList.add("hide"), view.querySelector(".fldCertPassword").classList.add("hide"), view.querySelector(".fldHttpsMode").classList.add("hide"), view.querySelector(".fldEnableUpnp").classList.add("hide"))
}), view.querySelector("#btnSelectCertPath").addEventListener("click", function() {
require(["directorybrowser"], function(directoryBrowser) {
var picker = new directoryBrowser;
Expand All @@ -141,11 +135,11 @@ define(["loading", "libraryMenu", "globalize", "emby-checkbox", "emby-select"],
})
});

view.querySelector(".dashboardHostingForm").addEventListener("submit", onSubmit), view.querySelector("#txtCertificatePath").addEventListener("change", onCertPathChange), view.addEventListener("viewshow", function(e) {
view.querySelector(".dashboardHostingForm").addEventListener("submit", onSubmit), view.addEventListener("viewshow", function(e) {
loading.show();
ApiClient.getServerConfiguration().then(function(config) {
loadPage(view, config);
});
});
}
});
});
7 changes: 1 addition & 6 deletions src/networking.html
Original file line number Diff line number Diff line change
Expand Up @@ -51,11 +51,6 @@ <h2 class="sectionTitle">${TabNetworking}</h2>
<div class="fieldDescription">${LabelPublicHttpsPortHelp}</div>
</div>

<div class="inputContainer fldDdns hide">
<input is="emby-input" id="txtDdns" type="text" label="${LabelExternalDDNS}" />
<div class="fieldDescription">${LabelExternalDDNSHelp}</div>
</div>

<div class="inputContainer fldBaseUrl">
<input is="emby-input" id="txtBaseUrl" type="text" label="${LabelBaseUrl}" />
<div class="fieldDescription">${LabelBaseUrlHelp}</div>
Expand Down Expand Up @@ -101,4 +96,4 @@ <h2 class="sectionTitle">${TabNetworking}</h2>
</form>
</div>
</div>
</div>
</div>
1 change: 0 additions & 1 deletion src/strings/ar.json
Original file line number Diff line number Diff line change
Expand Up @@ -385,7 +385,6 @@
"LabelEpisodeNumber": "رقم الحلقة:",
"LabelEvent": "الحدث:",
"LabelEveryXMinutes": "كل:",
"LabelExternalDDNS": "النطاق الخارجي:",
"LabelExtractChaptersDuringLibraryScan": "استخلص صور الأبواب أثناء تمشيط المكتبة",
"LabelExtractChaptersDuringLibraryScanHelp": "عند التفعيل، فإن صور الأبواب ستُستخلص عندما تدرج الفيديوهات الجديدة أثناء تمشيط المكتبة. عند عدم التفعيل فإن عملية الاستخلاص ستكون محصورة أثناء مهمة صور الأبواب المجدولة، ما يسمح لعملية تمشيط المكتبة أن تنتهي بصورة أسرع.",
"LabelFailed": "العملية فشلت",
Expand Down
1 change: 0 additions & 1 deletion src/strings/ca.json
Original file line number Diff line number Diff line change
Expand Up @@ -327,7 +327,6 @@
"LabelEpisodeNumber": "Episodi:",
"LabelEvent": "Esdeveniment:",
"LabelEveryXMinutes": "Cada:",
"LabelExternalDDNS": "Domini extern:",
"LabelExtractChaptersDuringLibraryScan": "Extrau imatges dels episodis durant l'escaneig de la biblioteca",
"LabelFailed": "Fallit",
"LabelFinish": "Finalitzar",
Expand Down
2 changes: 0 additions & 2 deletions src/strings/cs.json
Original file line number Diff line number Diff line change
Expand Up @@ -542,7 +542,6 @@
"LabelEpisodeNumber": "Číslo epizody:",
"LabelEvent": "Událost:",
"LabelEveryXMinutes": "Každý:",
"LabelExternalDDNS": "Externí doména:",
"LabelExternalPlayers": "Externí přehrávače:",
"LabelExtractChaptersDuringLibraryScan": "Extrakce obrázků kapitol během prohledávání vaší knihovny",
"LabelExtractChaptersDuringLibraryScanHelp": "Jestliže povolíte, budou snímky kapitol extrahovány při pravidelném prohledávání vaší knihovny. Pokud zakážete budou snímky extrahovány během naplánované úlohy pro extrakci snímků z kapitol, což umožní, při pravidelném prohledávání vaší knihovny, dokončit skenování rychleji.",
Expand Down Expand Up @@ -1377,7 +1376,6 @@
"LabelDynamicExternalId": "{0} ID:",
"LabelEmail": "E-mail:",
"LabelEnableHardwareDecodingFor": "Povolit hardwarové dekódování pro:",
"LabelExternalDDNSHelp": "Pokud máte dynamický DNS, zadejte jej zde. Aplikace Jellyfin jej budou používat při vzdáleném připojení. Toto pole je vyžadováno při použití s vlastním ssl certifikátem. Příklad: mojedomena.cz.",
"LabelHomeNetworkQuality": "Kvalita na domácí síti:",
"LabelInternetQuality": "Kvalita na internetu:",
"LabelKodiMetadataUser": "Uložení dat sledování uživatele do nfo pro:",
Expand Down
2 changes: 0 additions & 2 deletions src/strings/da.json
Original file line number Diff line number Diff line change
Expand Up @@ -477,8 +477,6 @@
"LabelEpisodeNumber": "Episodenummer:",
"LabelEvent": "Hændelse:",
"LabelEveryXMinutes": "Hver:",
"LabelExternalDDNS": "Eksternt domæne:",
"LabelExternalDDNSHelp": "Hvis du har en dynamisk DNS skriv den her. Jellyfin apps vil bruge den når de forbinder via fjernadgang. Dette felt er påkrævet når et brugerdefineret SSL certifikat bliver brugt. Eksempel: mydomain.com.",
"LabelExtractChaptersDuringLibraryScan": "Udtræk kapitelbilleder under biblioteksskanning",
"LabelExtractChaptersDuringLibraryScanHelp": "Aktiver dette for at udtrække kapitelbillleder mens videofiler bliver importeret under biblioteksskanningen. Hvi det ikke er aktiveret, bliver de udtrukket når den planlagte opgave kapitelbilleder kører, og lader den almindelige biblioteksskanning afslutte hurtigere.",
"LabelFailed": "Fejlet",
Expand Down
2 changes: 0 additions & 2 deletions src/strings/de.json
Original file line number Diff line number Diff line change
Expand Up @@ -589,8 +589,6 @@
"LabelEpisodeNumber": "Episodennummer:",
"LabelEvent": "Ereignis:",
"LabelEveryXMinutes": "Alle:",
"LabelExternalDDNS": "Externe Domain:",
"LabelExternalDDNSHelp": "Wenn Du einen dynamischen DNS verwendest gib ihn hier ein. Jellyfin Apps werden diesen für entfernte Verbindungen verwenden. Dieses Feld muss ausgefüllt werden, wenn ein eigenes SSL-Zertifikat verwendet wird. Beispiel: meineseite.de.",
"LabelExtractChaptersDuringLibraryScan": "Erzeuge Kapitelbilder während des Bibliothekscans",
"LabelExtractChaptersDuringLibraryScanHelp": "Fall aktiviert, werden Kapitelbilder während des Imports von Videos beim Bibliothekenscan erzeugt. Falls deaktiviert, werden die Kapitelbilder während einer eigens dafür geplanten Aufgabe erstellt, was den regelmäßig Bibliothekenscan beschleunigt.",
"LabelFailed": "Fehlgeschlagen",
Expand Down
2 changes: 0 additions & 2 deletions src/strings/el.json
Original file line number Diff line number Diff line change
Expand Up @@ -528,8 +528,6 @@
"LabelEpisodeNumber": "Νούμερο Επεισοδίου:",
"LabelEvent": "Γεγονός:",
"LabelEveryXMinutes": "Κάθε:",
"LabelExternalDDNS": "Εξωτερικό domain:",
"LabelExternalDDNSHelp": "Εάν έχετε ένα δυναμικό DNS, πληκτρολογήστε το εδώ. Οι εφαρμογές Jellyfin θα το χρησιμοποιούν όταν συνδέονται εξ αποστάσεως. Αυτό το πεδίο απαιτείται όταν χρησιμοποιείται με ένα προσαρμοσμένο πιστοποιητικό SSL. Παράδειγμα: mydomain.com.",
"LabelExtractChaptersDuringLibraryScan": "Εξαγωγή εικόνων κεφαλαίου κατά τη διάρκεια της σάρωσης βιβλιοθήκης",
"LabelExtractChaptersDuringLibraryScanHelp": "Αν είναι ενεργοποιημένη, οι εικόνες κεφαλαίων θα εξαχθούν όταν εισάγονται βίντεο κατά τη διάρκεια της σάρωσης της βιβλιοθήκης. Αν απενεργοποιηθούν, θα εξαχθούν κατά τη διάρκεια της προγραμματισμένης εργασίας των κεφαλαίων, επιτρέποντας την ταχύτερη ολοκλήρωση της σάρωσης κανονικής βιβλιοθήκης.",
"LabelFailed": "Αποτυχία",
Expand Down
2 changes: 0 additions & 2 deletions src/strings/en-us.json
Original file line number Diff line number Diff line change
Expand Up @@ -640,8 +640,6 @@
"LabelEpisodeNumber": "Episode number:",
"LabelEvent": "Event:",
"LabelEveryXMinutes": "Every:",
"LabelExternalDDNS": "External domain:",
"LabelExternalDDNSHelp": "If you have a dynamic DNS enter it here for clients to use when connecting remotely. This field is required when used with a custom SSL certificate. Example: mydomain.com.",
"LabelBaseUrl": "Base URL:",
"LabelBaseUrlHelp": "You can add a custom subdirectory here to access the server from a more unique URL.",
"LabelExtractChaptersDuringLibraryScan": "Extract chapter images during the library scan",
Expand Down
2 changes: 0 additions & 2 deletions src/strings/es-mx.json
Original file line number Diff line number Diff line change
Expand Up @@ -604,8 +604,6 @@
"LabelEpisodeNumber": "Episodio numero:",
"LabelEvent": "Evento:",
"LabelEveryXMinutes": "Cada:",
"LabelExternalDDNS": "Dominio externo:",
"LabelExternalDDNSHelp": "Si tiene un DNS dinámico introdúzcalo aquí. Las aplicaciones Jellyfin lo usaran cuando se conecte remotamente. Este campo es obligatorio si se utiliza un certificado ssl personalizado. Ejemplo: midominio.com.",
"LabelExtractChaptersDuringLibraryScan": "Extraer imágenes de capítulos durante la exploración de la biblioteca",
"LabelExtractChaptersDuringLibraryScanHelp": "Si se activa, las imágenes de capítulos serán extraídas cuando los videos sean importados durante la exploración de la biblioteca. Si se deshabilita, serán extraídas durante la ejecución de la tarea programada de extracción de imágenes de capítulos, permitiéndo que la exploración normal de la biblioteca se complete más rápidamente.",
"LabelFailed": "Fallido",
Expand Down
2 changes: 0 additions & 2 deletions src/strings/es.json
Original file line number Diff line number Diff line change
Expand Up @@ -539,8 +539,6 @@
"LabelEpisodeNumber": "Episodio número:",
"LabelEvent": "Evento:",
"LabelEveryXMinutes": "Cada:",
"LabelExternalDDNS": "Dominio externo:",
"LabelExternalDDNSHelp": "Si tienes un DNS dinámico introdúcelo aquí para usarlo al conectarse remotamente. Este campo es necesario cuando utilices un certificado SSL personalizado. Ejemplo: example.com.",
"LabelExtractChaptersDuringLibraryScan": "Extraer imágenes de los capítulos durante el escaneo de la biblioteca",
"LabelExtractChaptersDuringLibraryScanHelp": "Genera imágenes de capítulos cuando se importen vídeos durante el escaneo de las bibliotecas. Desmarcado, las imágenes se descargarán cuando se ejecute la tarea programada para ello, permitiendo un escaneo de la biblioteca más rápido.",
"LabelFailed": "Error",
Expand Down
2 changes: 0 additions & 2 deletions src/strings/fr.json
Original file line number Diff line number Diff line change
Expand Up @@ -599,8 +599,6 @@
"LabelEpisodeNumber": "Numéro d'épisode :",
"LabelEvent": "Évènement :",
"LabelEveryXMinutes": "Tous les :",
"LabelExternalDDNS": "Domaine extérieur :",
"LabelExternalDDNSHelp": "Si vous avez un DNS dynamique saisissez-le ici. Les applications Jellyfin vont l'utiliser pour les connexions distantes. Ce champ est obligatoire lorsqu'il est utilisé avec un certificat SSL personnalisé. Exemple : mondomaine.com.",
"LabelExtractChaptersDuringLibraryScan": "Extraire les images des chapitres pendant l'actualisation de la médiathèque",
"LabelExtractChaptersDuringLibraryScanHelp": "Si l'option est activée, les images des chapitres seront extraites lors de l'importation de vidéos pendant l'actualisation de la médiathèque. Sinon elles seront extraites pendant la tâche planifiée des images des chapitres, permettant de terminer plus rapidement les actualisations de la médiathèque.",
"LabelFailed": "Échoué",
Expand Down
1 change: 0 additions & 1 deletion src/strings/hr.json
Original file line number Diff line number Diff line change
Expand Up @@ -422,7 +422,6 @@
"LabelEpisodeNumber": "Broj epizode:",
"LabelEvent": "Događaj:",
"LabelEveryXMinutes": "Svaki:",
"LabelExternalDDNS": "Vanjska domena:",
"LabelExtractChaptersDuringLibraryScan": "Izvadi slike poglavlja dok traje skeniranje biblioteke",
"LabelExtractChaptersDuringLibraryScanHelp": "Ako je omogućeno, slike poglavlje će se izdvojiti kad se videozapisi uvezu tijekom skeniranja biblioteke. Ako je onemogućeno izdvojiti će se u rasporedu zadatka slika poglavlja, čime se omogućuje da se skeniranje redovne biblioteke završiti brže.",
"LabelFailed": "Neuspješno",
Expand Down
2 changes: 0 additions & 2 deletions src/strings/hu.json
Original file line number Diff line number Diff line change
Expand Up @@ -894,8 +894,6 @@
"LabelEnableSingleImageInDidlLimit": "Korlátozás egyetlen beágyazott képre",
"LabelEnableSingleImageInDidlLimitHelp": "Néhány eszköz nem jeleníti meg megfelelően, ha több kép van beágyazva a Didl-be.",
"LabelEndDate": "Befejezés dátuma:",
"LabelExternalDDNS": "Külső domain:",
"LabelExternalDDNSHelp": "Ha dinamikus DNS-t használsz, írd be ide. A Jellyfin alkalmazások fogják ezt használni távoli kapcsolódáskor. Ezt a mezőt akkor kell megadni ha egyéni SSL tanúsítványt használsz. Példa: mydomain.com.",
"LabelExtractChaptersDuringLibraryScan": "Fejezet képek készítése a könyvtár beolvasása során",
"LabelExtractChaptersDuringLibraryScanHelp": "Ha engedélyezve van, a fejezetképek elkészítése a könyvtár beolvasása során történik meg. Ha le van tiltva, akkor az elkészítés az Ütemezett feladatokban meghatározott időben készül el, ami lehetővé teszi a könyvtárbeolvasás gyorsítását.",
"LabelFailed": "Sikertelen",
Expand Down
2 changes: 0 additions & 2 deletions src/strings/it.json
Original file line number Diff line number Diff line change
Expand Up @@ -581,8 +581,6 @@
"LabelEpisodeNumber": "Numero espisodio:",
"LabelEvent": "Evento:",
"LabelEveryXMinutes": "Tutti:",
"LabelExternalDDNS": "Dominio esterno:",
"LabelExternalDDNSHelp": "Se hai un DNS dinamico inseriscilo qui. Le applicazioni Jellyfin lo useranno per le connessioni remote. Questo campo è richiesto quando si usa un certificato SSL personalizzato. Esempio: miodominio.com",
"LabelExtractChaptersDuringLibraryScan": "Estrarre immagini capitolo durante la scansione della libreria",
"LabelExtractChaptersDuringLibraryScanHelp": "Se abilitata, le immagini capitolo verranno estratti quando i video vengono importati durante la scansione della libreria. Se disabilitata verranno estratti durante l'operazione pianificata di estrazione delle immagini capitolo, permettendo la scansione della libreria più velocemente.",
"LabelFailed": "Fallito",
Expand Down
2 changes: 0 additions & 2 deletions src/strings/kk.json
Original file line number Diff line number Diff line change
Expand Up @@ -630,8 +630,6 @@
"LabelEpisodeNumber": "Bólim nómiri:",
"LabelEvent": "Oqıǵa:",
"LabelEveryXMinutes": "Ár:",
"LabelExternalDDNS": "Syrtqy domen:",
"LabelExternalDDNSHelp": "Eger sizde dınamıkalyq DNS bolsa, klıentter qashyqtan qosylǵanda paıdalaný úshin ony osynda engizińiz. Teńsheletin SSL-kýálikti paıdalanǵanda bul óris mindetti bolady. Mysaly: mydomain.com.",
"LabelExtractChaptersDuringLibraryScan": "Sahna sýretterin tasyǵyshhanany skanerleý mezgilinde shyǵaryp alý",
"LabelExtractChaptersDuringLibraryScanHelp": "Tasyǵyshhanany skanerleý kezinde beıneler shetten ákelingen jaǵdaıda, sahna sýretteri jasalady. Keri jaǵdaıda, bular sahna sýretterine josparlaǵan tapsyrmasy mezgilinde, turaqty tasyǵyshhanany skanerleýin jyldamyraq aıaqtalýy ushin ruqsat etip, bólinip alynady.",
"LabelFailed": "Sátsiz",
Expand Down
1 change: 0 additions & 1 deletion src/strings/lt-lt.json
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,6 @@
"LabelEpisodeNumber": "Serijos numeris:",
"LabelEvent": "Įvykis:",
"LabelEveryXMinutes": "Kas:",
"LabelExternalDDNS": "Išorinis domenas:",
"LabelFailed": "Nepavyko",
"LabelFinish": "Baigti",
"LabelFriendlyName": "Draugiškas pavadinimas:",
Expand Down

0 comments on commit 8c44662

Please sign in to comment.