Remove WAN domain name options #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was used in generation and modification of certificates, but since JF doesn't generate them and shouldn't modify them, I have removed these
|
Should be merged with jellyfin/jellyfin#1773 |
anthonylavado
approved these changes
Sep 19, 2019
joshuaboniface
approved these changes
Sep 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was used in generation and modification of certificates, but since JF doesn't generate them and shouldn't modify them, I have removed these.
There is a lot to untangle with regard to JF at least attempting to modify certs given to it, but this is a start.
Merge conflicts are likely easily resolvable. Caused by me removing unused translations.