Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification permission prompt interrupts input on first use #3243

Closed
freshgum-bubbles opened this issue Dec 27, 2021 · 3 comments · Fixed by #4935
Closed

Notification permission prompt interrupts input on first use #3243

freshgum-bubbles opened this issue Dec 27, 2021 · 3 comments · Fixed by #4935
Labels
bug Something isn't working confirmed The issue has been verified good first issue Good for newcomers

Comments

@freshgum-bubbles
Copy link

Describe The Bug

Upon signing into Jellyfin, the user is interrupted with a popup to allow notifications
when entering their username. This happens on the first character of the username.

Steps To Reproduce

  1. Log out, clear permissions from the page, etc.
  2. Get to the sign in page, enter a character of your username.
  3. The notification popup is shown when you type the first character of your username.

Expected Behavior

I think Jellyfin should wait for me to finish typing in my username and password (and possibly
even login) before prompting me asking for permission for notifications. This would mean I am
not interrupted when typing in my username (which is obviously quite annoying). Notifications are
an auxiliary thing and can wait; typing in my credentials is much more important.

Logs

Screenshots

System (please complete the following information):

  • Platform: [e.g. Linux, Windows, iPhone, Tizen]
  • Browser: [e.g. Firefox, Chrome, Safari]
  • Jellyfin Version: [e.g. 10.6.0]

Additional Context

It only happens in HTTPS due to the web platform not allowing the permission
to be garnered by HTTP websites. It also specifically happens when the first
character of the username is clicked, leading me to believe Jellyfin is waiting for
any form of user input then throwing up the notification permission popup as soon
as possible.

@freshgum-bubbles freshgum-bubbles added the bug Something isn't working label Dec 27, 2021
@freshgum-bubbles
Copy link
Author

Ahh, here is the code which seems to be causing all the trouble :D

@jellyfin-bot

This comment has been minimized.

@jellyfin-bot jellyfin-bot added the stale No activity for an extended length of time label Apr 27, 2022
@thornbill thornbill added confirmed The issue has been verified and removed stale No activity for an extended length of time labels Apr 27, 2022
@thornbill
Copy link
Member

In the code linked in the comment above, the event listeners should be added within an event listener for the localusersignedin. Examples of listening for this event can be found in several other places of the code.

@thornbill thornbill added the good first issue Good for newcomers label Oct 30, 2023
SimonTen pushed a commit to SimonTen/jellyfin-web that referenced this issue Nov 3, 2023
Previously the user is interrupted on first login with a popup to
allow notifications. Now the popup component checks if the user is
logged in already an if not it will listen to input event.

Resolves: jellyfin#3243
SimonTen pushed a commit to SimonTen/jellyfin-web that referenced this issue Nov 3, 2023
Previously the user is interrupted on first login with a popup to
allow notifications. Now the popup component checks if the user is
logged in already an if not it will listen to input event.

Resolves: jellyfin#3243
thornbill pushed a commit to SimonTen/jellyfin-web that referenced this issue Jan 18, 2024
Previously the user is interrupted on first login with a popup to
allow notifications. Now the popup component checks if the user is
logged in already an if not it will listen to input event.

Resolves: jellyfin#3243
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working confirmed The issue has been verified good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants