-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notification permission prompt interrupts input on first use #3243
Labels
bug
Something isn't working
confirmed
The issue has been verified
good first issue
Good for newcomers
Comments
Ahh, here is the code which seems to be causing all the trouble :D |
This comment has been minimized.
This comment has been minimized.
thornbill
added
confirmed
The issue has been verified
and removed
stale
No activity for an extended length of time
labels
Apr 27, 2022
In the code linked in the comment above, the event listeners should be added within an event listener for the |
SimonTen
pushed a commit
to SimonTen/jellyfin-web
that referenced
this issue
Nov 3, 2023
Previously the user is interrupted on first login with a popup to allow notifications. Now the popup component checks if the user is logged in already an if not it will listen to input event. Resolves: jellyfin#3243
SimonTen
pushed a commit
to SimonTen/jellyfin-web
that referenced
this issue
Nov 3, 2023
Previously the user is interrupted on first login with a popup to allow notifications. Now the popup component checks if the user is logged in already an if not it will listen to input event. Resolves: jellyfin#3243
thornbill
pushed a commit
to SimonTen/jellyfin-web
that referenced
this issue
Jan 18, 2024
Previously the user is interrupted on first login with a popup to allow notifications. Now the popup component checks if the user is logged in already an if not it will listen to input event. Resolves: jellyfin#3243
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
confirmed
The issue has been verified
good first issue
Good for newcomers
Describe The Bug
Upon signing into Jellyfin, the user is interrupted with a popup to allow notifications
when entering their username. This happens on the first character of the username.
Steps To Reproduce
Expected Behavior
I think Jellyfin should wait for me to finish typing in my username and password (and possibly
even login) before prompting me asking for permission for notifications. This would mean I am
not interrupted when typing in my username (which is obviously quite annoying). Notifications are
an auxiliary thing and can wait; typing in my credentials is much more important.
Logs
Screenshots
System (please complete the following information):
Additional Context
It only happens in HTTPS due to the web platform not allowing the permission
to be garnered by HTTP websites. It also specifically happens when the first
character of the username is clicked, leading me to believe Jellyfin is waiting for
any form of user input then throwing up the notification permission popup as soon
as possible.
The text was updated successfully, but these errors were encountered: