Wait for login before ask for notification permission #4935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
dmitrylyzo
reviewed
Nov 8, 2023
Previously the user is interrupted on first login with a popup to allow notifications. Now the popup component checks if the user is logged in already an if not it will listen to input event. Resolves: jellyfin#3243
Co-authored-by: Dmitry Lyzo <56478732+dmitrylyzo@users.noreply.github.com>
thornbill
force-pushed
the
issues/3243
branch
from
43fc9f9
to
a78fd22
Compare
|
Cloudflare Pages deployment
|
thornbill
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Previously the user was interrupted on first login with a popup to allow notifications.
Now the popup component checks if there is a current user and if not it will listen to the login event, to register the eventlisteners wich trigger the permission request
Issues
Fixes: #3243