Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Babel query-string to support older browsers #1026

Merged
merged 1 commit into from
Apr 8, 2020

Conversation

dmitrylyzo
Copy link
Contributor

@dmitrylyzo dmitrylyzo commented Apr 4, 2020

Babel query-string to support older browsers (Tizen 3 ~ Chrome 47).

Changes

  • Include query-string for "babeling".
  • Make global babel config.

If there is a more correct way to do this, feel free to replace this PR

@dmitrylyzo
Copy link
Contributor Author

dmitrylyzo commented Apr 4, 2020

It seems that all other presets can be removed - I got equal dist folder content with global babel config.

@JustAMan
Copy link
Contributor

JustAMan commented Apr 8, 2020

I wonder why we don't babelize the whole node_modules...

@heyhippari
Copy link
Contributor

I wonder why we don't babelize the whole node_modules...

I think most packages, by default, set their export to the transpiled, bundled file in their dist directory.

Setting your default export to the entry point of the source version seems to be the exeption.

@dkanada dkanada merged commit e3007b8 into jellyfin:master Apr 8, 2020
@dmitrylyzo dmitrylyzo deleted the babel_query_string branch February 20, 2022 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants