Fix native hls resume #1040
Merged
Fix native hls resume #1040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes mobile Chrome, Android WebView and probably some Apple devices
Also make Safari to resume previous position faster
thornbill
approved these changes
Apr 7, 2020
|
What else should we look into fixing for an android release? |
|
We just need to add the GitHub and webhook releases to the CI for a new Android release. |
heyhippari
suggested changes
Apr 7, 2020
IMHO this jellyfin/JavascriptSubtitlesOctopus#14 plus new Octopus release plus bumped Octopus release in jf-web so Android gets client-side rendering of SSA back. |
heyhippari
approved these changes
Apr 7, 2020
This was referenced Apr 8, 2020
joshuaboniface
pushed a commit
that referenced
this pull request
Apr 12, 2020
Fix native hls resume (cherry picked from commit 2223a16) Signed-off-by: Joshua M. Boniface <joshua@boniface.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Remove the hack that was used to resume HLS from previous position on Safari (actually it was used to resume everything, even direct plays, so Safari should have played 2.5 seconds of the beginning always) and implement a proper event-driven way to seek the stream only when it's really ready to be sought (should usually be faster than 2.5 seconds, but in reality depends on the bandwidth and the server).
Issues
Fixes the broken resume of non-direct play on mobile Chrome and Android app: