Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Zoom In on Photos #1116

Merged
merged 2 commits into from
Apr 23, 2020

Conversation

samuel9554
Copy link
Contributor

Added Zoom in on photo feature requested in issue #857

Changes
Update swiper dependencies to 5.3.7 since there were a issue with the zoom feature.

On mobile
ezgif-7-4468f6608443

On browser.
ezgif-7-a1f2ca7edbea

@sonarcloud
Copy link

sonarcloud bot commented Apr 22, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@heyhippari heyhippari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Wasn't able to test on desktop, so we might need to add Zoom + and - buttons on desktop at some point.

@samuel9554
Copy link
Contributor Author

But you can rapidly double click on where you want to zoom for the desktop version.

P.s. I want to get better with Jellyfin and have a better understanding of it. If you have other project like that notfiy me.

@heyhippari
Copy link
Contributor

But you can rapidly double click on where you want to zoom for the desktop version.

Indeed! Seems like it was a user error :p

Although I seem to be having some issues with pictures that have a portrait aspect ratio. Somehow the zoomed out picture doesn't "fit" in the window and the bottom is cut out.

I want to get better with Jellyfin and have a better understanding of it. If you have other project like that notfiy me.

We've been trying to get better with tagging issues to make them more accessible to new contributors. I'll try to go through all the issues and mark all the good first issues I find.

@dkanada dkanada merged commit 928e2f7 into jellyfin:master Apr 23, 2020
@samuel9554 samuel9554 deleted the Zoom_In_on_Photos branch April 23, 2020 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants