-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename Mixed Content and TV Shows #1271
Conversation
This should probably be done via Weblate actually. |
If we're making this change, I propose we also rename TV Shows to Shows for a slightly more generic term. If we don't make this change then disregard my comment. |
Renamed TV Shows to Shows |
Kudos, SonarCloud Quality Gate passed!
|
“Custom” just seems so ambiguous. I believe that type is for unorganized combinations of tv shows and movies because it still scrapes metadata right? I seem to recall you being vetoed on the “shows” change in the past @dkanada. Although I don’t personally have a preference on that one. |
I was at the time because users were confused with the change, but if we're apparently renaming mixed content I figured I'd bring it up again. |
Mixed Content's current job as mixing tv shows and movies doesnt work well and there's no real plans for us to fix the regex to make it perfect. I think Custom is a better approach because it's the actual intent of the Library, I do think we should change the metadata grabbers default to off so that you can enable them if you want, but they're OFF because they're not the real intent. It'll make more sense once we have additional metadata grabbers like YouTube and such. |
Changes
Issues