Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Mixed Content and TV Shows #1271

Closed
wants to merge 2 commits into from
Closed

Rename Mixed Content and TV Shows #1271

wants to merge 2 commits into from

Conversation

Artiume
Copy link
Contributor

@Artiume Artiume commented May 19, 2020

Changes

Issues

@Artiume
Copy link
Contributor Author

Artiume commented May 19, 2020

This should probably be done via Weblate actually.

@dkanada
Copy link
Member

dkanada commented May 27, 2020

If we're making this change, I propose we also rename TV Shows to Shows for a slightly more generic term. If we don't make this change then disregard my comment.

@Artiume Artiume changed the title Rename Mixed Content to Custom Rename Mixed Content and TV Shows May 27, 2020
@Artiume
Copy link
Contributor Author

Artiume commented May 27, 2020

Renamed TV Shows to Shows

@sonarcloud
Copy link

sonarcloud bot commented May 27, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@thornbill
Copy link
Member

“Custom” just seems so ambiguous. I believe that type is for unorganized combinations of tv shows and movies because it still scrapes metadata right?

I seem to recall you being vetoed on the “shows” change in the past @dkanada. Although I don’t personally have a preference on that one.

@dkanada
Copy link
Member

dkanada commented May 27, 2020

I was at the time because users were confused with the change, but if we're apparently renaming mixed content I figured I'd bring it up again.

@Artiume
Copy link
Contributor Author

Artiume commented May 27, 2020

Mixed Content's current job as mixing tv shows and movies doesnt work well and there's no real plans for us to fix the regex to make it perfect. I think Custom is a better approach because it's the actual intent of the Library, I do think we should change the metadata grabbers default to off so that you can enable them if you want, but they're OFF because they're not the real intent. It'll make more sense once we have additional metadata grabbers like YouTube and such.

@heyhippari heyhippari added this to Active PRs in Release 10.7.0 via automation Jun 10, 2020
@dkanada dkanada closed this in #1896 Sep 3, 2020
Release 10.7.0 automation moved this from Active PRs to Completed PRs Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Release 10.7.0
  
Completed PRs
Development

Successfully merging this pull request may close these issues.

None yet

4 participants