Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a common error message and update some strings #1896

Merged
merged 2 commits into from Sep 3, 2020
Merged

Fix a common error message and update some strings #1896

merged 2 commits into from Sep 3, 2020

Conversation

dkanada
Copy link
Member

@dkanada dkanada commented Sep 2, 2020

closes #1271

dkanada
dkanada commented Sep 2, 2020
View reviewed changes
src/controllers/dashboard/library.js
name: globalize.translate('FolderTypeMusic'),
name: globalize.translate('TabMusic'),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't feel like replacing the key everywhere it shows up but let me know if this is a blocker.

@sonarcloud
Copy link

sonarcloud bot commented Sep 2, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dkanada dkanada merged commit 87484e1 into master Sep 3, 2020
@dkanada dkanada deleted the errors branch October 8, 2020 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camc314 camc314 camc314 approved these changes

@heyhippari heyhippari heyhippari approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dkanada @camc314 @heyhippari