Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kill Yoda #1333

Merged
merged 2 commits into from
Jul 31, 2020
Merged

Kill Yoda #1333

merged 2 commits into from
Jul 31, 2020

Conversation

heyhippari
Copy link
Contributor

@heyhippari heyhippari commented May 31, 2020 •
edited
Loading

Changes

Enable errors on inverted conditions.

This will cause an error:

if ('dead' === yoda) {
    // ...
}

This will not:

if (yoda === 'dead') {
    // ...
}

image

@sonarcloud
Copy link

sonarcloud bot commented May 31, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
12.3% 12.3% Duplication

ferferga
ferferga approved these changes Jun 8, 2020
View reviewed changes
Copy link
Member

@ferferga ferferga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YOLO

@sonarcloud
Copy link

sonarcloud bot commented Jul 31, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
5.1% 5.1% Duplication

@dkanada dkanada merged commit f430518 into jellyfin:master Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ferferga ferferga ferferga approved these changes

@DesertCookie DesertCookie DesertCookie approved these changes

@camc314 camc314 camc314 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@heyhippari @ferferga @DesertCookie @camc314 @dkanada