Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix required track count for subtitle selector to appear #1627

Merged
merged 1 commit into from
Jul 23, 2020
Merged

Fix required track count for subtitle selector to appear #1627

merged 1 commit into from
Jul 23, 2020

Conversation

rom4nik
Copy link
Contributor

@rom4nik rom4nik commented Jul 22, 2020 •
edited
Loading

Since this commit the subtitle selector was getting disabled for videos with both 0 or 1 subtitle track available, thus making it impossible to start playback of the latter without subs.

Before:
before1

After:
after1

@sonarcloud
Copy link

sonarcloud bot commented Jul 22, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

heyhippari
heyhippari approved these changes Jul 22, 2020
View reviewed changes
Copy link
Contributor

@heyhippari heyhippari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@heyhippari heyhippari added the stable backport Backport into the next stable release label Jul 22, 2020
@dkanada dkanada merged commit 120ce4f into jellyfin:master Jul 23, 2020
joshuaboniface pushed a commit that referenced this pull request Jul 27, 2020
@dkanada @joshuaboniface
Merge pull request #1627 from rom4nik/master
7f133ff 
Fix required track count for subtitle selector to appear

(cherry picked from commit 120ce4f)
Signed-off-by: Joshua M. Boniface <joshua@boniface.me>
@joshuaboniface joshuaboniface removed the stable backport Backport into the next stable release label Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camc314 camc314 camc314 approved these changes

@heyhippari heyhippari heyhippari approved these changes

@dkanada dkanada dkanada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rom4nik @camc314 @heyhippari @dkanada @joshuaboniface