Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove translations with duplicate values #1839

Merged
merged 13 commits into from
Aug 31, 2020
Merged

Remove translations with duplicate values #1839

merged 13 commits into from
Aug 31, 2020

Conversation

dkanada
Copy link
Member

@dkanada dkanada commented Aug 23, 2020

OptionPlayed
OptionUnplayed
OptionFavorite
OptionContinuing
OptionEnded
OptionHasSubtitles
OptionHasTrailer
OptionDownloadArtImage
OptionDownloadBackImage
OptionDownloadBannerImage
OptionDownloadBoxImage
OptionDownloadDiscImage
ButtonRestart
OptionProfileAudio
TabSettings
OptionAuto
OptionHomeVideos
ButtonSettings
TabProfile
OptionBlockBooks
OptionBlockMovies
OptionBlockMusic
ButtonResetPassword
OptionRuntime
OptionAlbumArtist
OptionAlbum
OptionArtist
HeaderSettings
ButtonProfile
OptionAscending
OptionDescending
ButtonSelectServer
ButtonSettings
ButtonGuide
OptionHasSpecialFeatures
OptionDownloadPrimaryImage
OptionDownloadLogoImage
OptionDownloadThumbImage
OptionDownloadMenuImage
OptionNone
OptionBlockChannelContent
OptionBlockLiveTvChannels
OptionBlockTrailers
OptionBlockTvShows
HeaderSpecialFeatures
HeaderMusicVideos
LabelVideo
OptionNameSort

@EraYaN
Copy link
Member

EraYaN commented Aug 25, 2020

This does seem to introduce a bunch of in consistencies, with "neighboring" translations. Like some lists now have three with some prefix and then one without (for example the "Audio" one).

@dkanada
Copy link
Member Author

dkanada commented Aug 27, 2020

The only items left with dynamic translations are included in the list below. I'm also including the favorite headers because I think the prefix is redundant.

ColorPrimaries
ColorSpace
ColorTransfer
HeaderFavoriteBooks
HeaderFavoriteMovies
HeaderFavoriteShows
HeaderFavoriteEpisodes
HeaderFavoriteAlbums
HeaderFavoritePeople
HeaderFavoriteArtists
HeaderFavoriteSongs
HeaderFavoriteVideos
HeaderFavoritePlaylists
MediaInfoStreamTypeAudio
MediaInfoStreamTypeData
MediaInfoStreamTypeEmbeddedImage
MediaInfoStreamTypeSubtitle
MediaInfoStreamTypeVideo
OptionBanner
OptionList
OptionPoster
OptionPosterCard
OptionThumb
OptionThumbCard
PlaybackErrorNoCompatibleStream

@dkanada dkanada requested a review from EraYaN August 27, 2020 06:58
@dkanada dkanada merged commit 87397da into master Aug 31, 2020
@dkanada dkanada deleted the strings branch August 31, 2020 14:47
@sonarcloud
Copy link

sonarcloud bot commented Aug 31, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
13.0% 13.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants