Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove touch controls from video player #2266

Merged
merged 3 commits into from
Feb 16, 2021
Merged

remove touch controls from video player #2266

merged 3 commits into from
Feb 16, 2021

Conversation

dkanada
Copy link
Member

@dkanada dkanada commented Dec 26, 2020

No description provided.

@sonarcloud
Copy link

sonarcloud bot commented Dec 27, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@thornbill
Copy link
Member

Why are these controls being removed?

@dkanada
Copy link
Member Author

dkanada commented Jan 2, 2021

Touch controls on an HTML video player are already unreliable in my experience, but these are especially troublesome. The Android app is also migrating over to ExoPlayer (and native touch controls) for a much better experience, so I consider it an improvement to remove these controls on the web player.

@thornbill thornbill added the discussion needed Requires input from the community label Jan 4, 2021
@thornbill
Copy link
Member

thornbill commented Jan 21, 2021 •
edited by dkanada
Loading

Based on our discussion on Matrix, I don't object to removing this, but we need an issue to track the following:

  • Known issues with the current implementation that justify its removal
  • Functional requirements for a new implementation

@thornbill thornbill added blocked Requires work on the web client to finish and removed discussion needed Requires input from the community labels Jan 21, 2021
@dkanada
Copy link
Member Author

dkanada commented Feb 6, 2021

#2377

@dkanada dkanada added stable backport Backport into the next stable release and removed blocked Requires work on the web client to finish labels Feb 6, 2021
@thornbill thornbill removed the stable backport Backport into the next stable release label Feb 14, 2021
@thornbill thornbill merged commit f416b4a into master Feb 16, 2021
@thornbill thornbill deleted the touch-controls branch February 16, 2021 18:33
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thornbill thornbill thornbill approved these changes

@dmitrylyzo dmitrylyzo dmitrylyzo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dkanada @thornbill @dmitrylyzo