Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tiny card icons #2306

Merged
merged 1 commit into from
Jan 7, 2021
Merged

Fix tiny card icons #2306

merged 1 commit into from
Jan 7, 2021

Conversation

thornbill
Copy link
Member

Changes

  • Reverts a change from Add more icon types #813. It seems like that change was intended to fix an issue on the item details screen where the placeholder icons were the incorrect size. It appears to no longer be an issue since the item details screen now uses cards. Reverting it fixes an issue where some icons on cards are the wrong size.

Before:
Screenshot_2021-01-04 Jellyfin

After:
Screenshot_2021-01-04 Jellyfin(1)

(For reference this is the Users screen in the Admin Dashboard.)

Issues
N/A

@thornbill thornbill added the stable backport Backport into the next stable release label Jan 4, 2021
@thornbill thornbill added this to Active PRs in Release 10.7.0 via automation Jan 4, 2021
@sonarcloud
Copy link

sonarcloud bot commented Jan 4, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.1% 1.1% Duplication

@thornbill thornbill merged commit e2c4418 into jellyfin:master Jan 7, 2021
Release 10.7.0 automation moved this from Active PRs to Completed PRs Jan 7, 2021
@thornbill thornbill deleted the fix-tiny-icons branch January 7, 2021 21:50
joshuaboniface pushed a commit that referenced this pull request Jan 23, 2021
@thornbill @joshuaboniface
Merge pull request #2306 from thornbill/fix-tiny-icons
e8028aa 
Fix tiny card icons

(cherry picked from commit e2c4418)
Signed-off-by: Joshua M. Boniface <joshua@boniface.me>
@joshuaboniface joshuaboniface moved this from Completed PRs to Jellyfinished in Release 10.7.0 Jan 23, 2021
@joshuaboniface joshuaboniface removed the stable backport Backport into the next stable release label Jan 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heyhippari heyhippari heyhippari approved these changes

@dkanada dkanada dkanada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Release 10.7.0
  
Jellyfinished
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@thornbill @heyhippari @dkanada @joshuaboniface