Add padding to prevent music controls from clipping #2467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitrylyzo
reviewed
Mar 4, 2021
|
@albeeeert did you have any comments about the suggestions? |
…ary views to prevent music control clipping
|
Kudos, SonarCloud Quality Gate passed!
|
albeeeert
changed the title
|
Made changes as @dmitrylyzo stated in the latest commit. Seems to work and I agree that the itemsContainer was way too generic. |
dmitrylyzo
approved these changes
Mar 24, 2021
dkanada
approved these changes
Mar 26, 2021
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add bottom padding for artist view and e.g. photos view to prevent music controls from clipping with information. Removes a needless inline style from list.html.
Issues
Fixes issue #2314.