Use custom modals on webOS and Tizen 2.x #3031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitrylyzo
added
blocked
dmitrylyzo
force-pushed
the
webos-modals
branch
from
a638e50
to
965e7c9
Compare
dmitrylyzo
force-pushed
the
webos-modals
branch
from
965e7c9
to
527215e
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
thornbill
approved these changes
Oct 25, 2021
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, there is no modal dialog (alert, confirm) on webOS - it probably blocks them.
Also, Tizen 2.3 (jellyfin/jellyfin-tizen#83 (comment)) does the same.
But we cannot merge this until #3030 and playback error (#3046) are fixed.
Changes
Use custom modals on webOS and Tizen 2.x
Issues
There is no modal dialog (alert, confirm) on webOS and Tizen 2.3
Fixes jellyfin/jellyfin-tizen#83