Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update displaySettings.template.html #3171

Merged
merged 8 commits into from
Nov 20, 2021
Merged

Conversation

WWWesten
Copy link
Contributor

@WWWesten WWWesten commented Nov 13, 2021

Synchronize language names list with jelliyfin core and language codes in list with language resource file names. Native names of the languages, exposed the language codes, order by the language codes.

Changes

Issues

@WWWesten
Copy link
Contributor Author

Related to jellyfin/jellyfin#6839

@WWWesten
Copy link
Contributor Author

WWWesten commented Nov 16, 2021

@dmitrylyzo Can You, if you take a moment, review the PR? Thanks.

Copy link
Contributor

@dmitrylyzo dmitrylyzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WWWesten Do you mind if I rebase your master branch after we are done?
Again, please create a separate branch next time: that way you don't have to constantly merge the upstream master, unless there is a conflict.

@WWWesten
Copy link
Contributor Author

WWWesten commented Nov 17, 2021

I rebase your master branch
I'm afraid I don't understand what that means. I don't have much experience with Github.

create a separate branch
I can't do it. I don't see any button to imply this.

@dmitrylyzo
Copy link
Contributor

I'm afraid I don't understand what that means. I don't have much experience with Github.

I will do it via git CLI. But then you will have to reset HEAD of your working directory (cloned repo).
Or do you work directly on GitHub?

I can't do it. I don't see any button to imply this.

If you're not using git CLI or other tools, I see it this way:

  1. Fetch upstream being on your master. master should be just fast-forwarded - no merge commits
  2. Click Switch branch and type the name of the new branch.
    branch
  3. You are on the new branch (switch it if you are not).
    branch2

Copy link
Contributor

@dmitrylyzo dmitrylyzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have rebased your master - now history is cleaner.

@dmitrylyzo
Copy link
Contributor

What happened? It was merged again 😕

@WWWesten
Copy link
Contributor Author

I have Github Desktop 2.9.4. (x64) installed and I do not see what you have in the picture.

@WWWesten
Copy link
Contributor Author

What happened? It was merged again 😕
What You mean?

@dmitrylyzo
Copy link
Contributor

I have Github Desktop 2.9.4. (x64) installed and I do not see what you have in the picture.

Oh, I believe that is in the Current branch dropdown.

What You mean?

merge
I think this how Github Desktop pulled force pushed master.
How did you move your master after thornbill rebased your previous PR?

@WWWesten
Copy link
Contributor Author

Hi @thornbill, can You take a look and merge PR? Thanks.

@thornbill
Copy link
Member

I would prefer that all the merge commits were not included in this. I'm not sure how you are updating the branch, but it's typically not necessary unless there is a conflict with the base branch. Even then it would be "cleaner" to rebase and force push instead.

I will try to get it cleaned up and merged soon.

WWWesten and others added 8 commits November 20, 2021 00:01
Synchronize language names list with jelliyfin core and language codes in list with language resource file names
Native names of the languages, exposed the language codes, order by the language codes
Co-authored-by: Dmitry Lyzo <56478732+dmitrylyzo@users.noreply.github.com>
Co-authored-by: Dmitry Lyzo <56478732+dmitrylyzo@users.noreply.github.com>
@sonarcloud
Copy link

sonarcloud bot commented Nov 20, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@thornbill thornbill merged commit 2043c1b into jellyfin:master Nov 20, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants