-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update displaySettings.template.html #3171
Conversation
Related to jellyfin/jellyfin#6839 |
@dmitrylyzo Can You, if you take a moment, review the PR? Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@WWWesten Do you mind if I rebase your master
branch after we are done?
Again, please create a separate branch next time: that way you don't have to constantly merge the upstream master
, unless there is a conflict.
|
I will do it via git CLI. But then you will have to reset HEAD of your working directory (cloned repo).
If you're not using git CLI or other tools, I see it this way: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have rebased your master
- now history is cleaner.
What happened? It was merged again 😕 |
I have Github Desktop 2.9.4. (x64) installed and I do not see what you have in the picture. |
|
Hi @thornbill, can You take a look and merge PR? Thanks. |
I would prefer that all the merge commits were not included in this. I'm not sure how you are updating the branch, but it's typically not necessary unless there is a conflict with the base branch. Even then it would be "cleaner" to rebase and force push instead. I will try to get it cleaned up and merged soon. |
Synchronize language names list with jelliyfin core and language codes in list with language resource file names
Native names of the languages, exposed the language codes, order by the language codes
Remove language codes
Co-authored-by: Dmitry Lyzo <56478732+dmitrylyzo@users.noreply.github.com>
Co-authored-by: Dmitry Lyzo <56478732+dmitrylyzo@users.noreply.github.com>
Kudos, SonarCloud Quality Gate passed! |
Synchronize language names list with jelliyfin core and language codes in list with language resource file names. Native names of the languages,
exposed the language codes,order by the language codes.Changes
Issues