Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try to determine the number of speakers before falling back to hardcoded values #3344

Merged
merged 1 commit into from
Jan 20, 2022
Merged

Try to determine the number of speakers before falling back to hardcoded values #3344

merged 1 commit into from
Jan 20, 2022

Conversation

knackebrot
Copy link
Contributor

@knackebrot knackebrot commented Jan 16, 2022 •
edited
Loading

This is split from my old PR: #2511

Changes
If the user hasn't specified his desired number of audio channels, try to determine it from the browser. This effectively reduces the number of audio channels from 6 to 2 for most users when transcoding.

@dmitrylyzo
Copy link
Contributor

dmitrylyzo commented Jan 17, 2022 •
edited
Loading

@knackebrot Please remove || '-1' at the same line - as I said, allowedAudioChannels has it inside.

jellyfin-web/src/scripts/settings/userSettings.js

Line 127 in b0a0593

return this.get('allowedAudioChannels', false) || '-1';

@knackebrot
Copy link
Contributor Author

@knackebrot Please remove || '-1' at the same line - as I said, allowedAudioChannels has it inside.

jellyfin-web/src/scripts/settings/userSettings.js

Line 127 in b0a0593

return this.get('allowedAudioChannels', false) || '-1';

sorry, fixed now.

@sonarcloud
Copy link

sonarcloud bot commented Jan 17, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.4% 0.4% Duplication

dmitrylyzo
dmitrylyzo approved these changes Jan 17, 2022
View reviewed changes
Copy link
Contributor

@dmitrylyzo dmitrylyzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thornbill thornbill added the enhancement Improve existing functionality or small fixes label Jan 20, 2022
@thornbill thornbill merged commit 84a3fd7 into jellyfin:master Jan 20, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitrylyzo dmitrylyzo dmitrylyzo approved these changes

Assignees
No one assigned
Labels
enhancement Improve existing functionality or small fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@knackebrot @dmitrylyzo @thornbill