Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix click on item details poster playing wrong item #3478

Merged
merged 1 commit into from
Mar 3, 2022
Merged

Fix click on item details poster playing wrong item #3478

merged 1 commit into from
Mar 3, 2022

Conversation

thornbill
Copy link
Member

@thornbill thornbill commented Mar 2, 2022 •
edited
Loading

Changes

  • Disables the hover menu on the poster card on the item details screen
  • Fixes clicking on the card not playing the selected source

It seems cards do not currently support specifying a specific source for an item, so the actions in the hover menu always act on the first source.

Issues
Fixes #2370

@thornbill thornbill added the bug Something isn't working label Mar 2, 2022
@sonarcloud
Copy link

sonarcloud bot commented Mar 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@thornbill thornbill merged commit 2f7a66b into jellyfin:master Mar 3, 2022
@thornbill thornbill deleted the fix-item-details-card-action branch March 3, 2022 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nielsvanvelzen nielsvanvelzen nielsvanvelzen approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Item Details Poster - Doesn't play selected version
2 participants
@thornbill @nielsvanvelzen