Fix backdrop being used on large screens in mobile layout #3618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thornbill
added
bug
|
Kudos, SonarCloud Quality Gate passed!
|
crobibero
approved these changes
May 5, 2022
jellyfin-bot
pushed a commit
that referenced
this pull request
May 21, 2022
Fix backdrop being used on large screens in mobile layout (cherry picked from commit f2c27dc) Signed-off-by: Joshua Boniface <joshua@boniface.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This fixes an issue where the backdrop was enabled on the item details screen on large devices (tablets) that use the mobile layout. The backdrops are not compatible with the header styling used for the mobile layout.
Issues
As you can see in the following screenshot, the header image and backdrop are not aligned. The header image also scrolls with the page while the backdrop remains fixed in the mobile layout.