Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove play button highlighting #3657

Merged
merged 1 commit into from May 20, 2022
Merged

Remove play button highlighting #3657

merged 1 commit into from May 20, 2022

Conversation

dmitrylyzo
Copy link
Contributor

@dmitrylyzo dmitrylyzo commented May 20, 2022 •
edited

Looks like I dragged this highlighting to Desktop and Mobile in #3443

Originally it was in TV only.

from #1845
I used a FAB for the play button (Set dynamically between play and resume, depending on what should be the primary action) in order to make it more obvious as to what the default action is.

Changes
Remove play button highlighting

Issues
Fixes #3320

Screenshots

Was Now

For reference, this is what the active button (More) in TV looks like:

@dmitrylyzo dmitrylyzo added this to Active PRs in Release 10.8.0 via automation May 20, 2022
@dmitrylyzo dmitrylyzo added the ui & ux This PR or issue mainly concerns UI & UX label May 20, 2022
@sonarcloud
Copy link

sonarcloud bot commented May 20, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dmitrylyzo dmitrylyzo added the stable backport Backport into the next stable release label May 20, 2022
Release 10.8.0 automation moved this from Active PRs to Approved PRs May 20, 2022
@thornbill thornbill merged commit 6b362fb into jellyfin:release-10.8.z May 20, 2022
Release 10.8.0 automation moved this from Approved PRs to Completed PRs May 20, 2022
jellyfin-bot pushed a commit that referenced this pull request May 21, 2022
@thornbill @joshuaboniface
Merge pull request #3657 from dmitrylyzo/unhighlight-play
311e271 
Remove play button highlighting

(cherry picked from commit 6b362fb)
Signed-off-by: Joshua Boniface <joshua@boniface.me>
@jellyfin-bot jellyfin-bot moved this from Completed PRs to Jellyfinished in Release 10.8.0 May 21, 2022
@jellyfin-bot jellyfin-bot removed the stable backport Backport into the next stable release label May 21, 2022
@dmitrylyzo dmitrylyzo deleted the unhighlight-play branch May 21, 2022 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thornbill thornbill thornbill approved these changes

Assignees
No one assigned
Labels
ui & ux This PR or issue mainly concerns UI & UX
Projects
No open projects
Release 10.8.0
  
Jellyfinished
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dmitrylyzo @thornbill @jellyfin-bot