Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Babelify @jellyfin/libass-wasm #4356

Merged
merged 2 commits into from
Feb 19, 2023

Conversation

dmitrylyzo
Copy link
Contributor

Changes

  • Simplify adding modules to babel-loader
  • Babelify @jellyfin/libass-wasm

Issues
libass-wasm must be transpiled because of the forgotten const. This will also be helpful when migrating to ES6.
jellyfin/jellyfin-webos#31 (comment)

@dmitrylyzo dmitrylyzo added the bug Something isn't working label Feb 14, 2023
@sonarcloud
Copy link

sonarcloud bot commented Feb 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@thornbill thornbill merged commit 8f75a42 into jellyfin:release-10.8.z Feb 19, 2023
@dmitrylyzo dmitrylyzo deleted the babel-libass branch February 19, 2023 17:11
@ThaUnknown
Copy link
Contributor

note that this doesn't transpile the workers, also with this change libass-wasm should be excluded from /.escheckrc

@etu
Copy link

etu commented May 1, 2023

Heya, I've ran into problems after the update of Jellyfin(-web) to 10.8.10, had no idea what was going on because Jellyfin worked on my phone and in my browser. However, it didn't load on my LG TV that runs WebOS.

So without being sure about anything I opened this ticket jellyfin/jellyfin-webos#154 and rolled my system back to a version prior.

Now when I had some time over I tried to roll back only jellyfin to 10.8.9 (not jellyfin-web, it was still on 10.8.10) or anything else and it was still broken so I assumed it was something else in the system, maybe nginx or something.

Some hours later of bisecting nixpkgs/nixos I found that the breakage were due to jellyfin-web and not jellyfin.

So I spent some time bisecting jellyfin-web and trying out specific commits, bisect log available here: jellyfin/jellyfin-webos#154 (comment)

So... yeah, that pointed me here. This PR broke Jellyfin-web on LG WebOS 5 TV's. Not sure why though, I'm not sure if I have a way to inspect the browser or so. I don't even have developer tools on it enabled... 🙂

etu added a commit to etu/nixconfig that referenced this pull request May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants