Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show error message on playback failure #5402

Merged
merged 3 commits into from
May 1, 2024

Conversation

dmitrylyzo
Copy link
Contributor

@dmitrylyzo dmitrylyzo commented Apr 20, 2024

Changes

  • Linearize Promises.
  • Fix LiveTV loading not hide on fail.
  • Show error message on playback failure.

Issues
N/A

@dmitrylyzo dmitrylyzo added bug Something isn't working enhancement Improve existing functionality or small fixes ui & ux This PR or issue mainly concerns UI & UX labels Apr 20, 2024
Copy link

sonarcloud bot commented Apr 24, 2024

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.9% Duplication on New Code

See analysis details on SonarCloud

@dmitrylyzo dmitrylyzo changed the title Fix LiveTV loading not hide on fail Show error message on playback failure Apr 24, 2024
@dmitrylyzo dmitrylyzo marked this pull request as ready for review April 24, 2024 08:54
@dmitrylyzo dmitrylyzo requested a review from a team as a code owner April 24, 2024 08:54
@jellyfin-bot
Copy link
Collaborator

Cloudflare Pages deployment

Latest commit 3a87e2c
Status ✅ Deployed!
Preview URL https://26bbfaaf.jellyfin-web.pages.dev
Type 🔀 Preview

View build logs
View bot logs

@dmitrylyzo dmitrylyzo added this to the v10.9.0 milestone Apr 26, 2024
@thornbill thornbill merged commit 1b2c99a into jellyfin:master May 1, 2024
12 checks passed
@dmitrylyzo dmitrylyzo deleted the fix-livetv-loading branch May 2, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement Improve existing functionality or small fixes ui & ux This PR or issue mainly concerns UI & UX
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants