Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix can't connect to server if enableAutoLogin is false #600

Merged
merged 1 commit into from Nov 28, 2019
Merged

Fix can't connect to server if enableAutoLogin is false #600

merged 1 commit into from Nov 28, 2019

Conversation

Wunax
Copy link
Contributor

@Wunax Wunax commented Nov 26, 2019

Issues
Fix #599

@dkanada
Copy link
Member

dkanada commented Nov 26, 2019

We are actually in the process of migrating the API client over to this repository, since it makes more sense as a separate project. Any chance you could also add a pull request there so we don't forget it? Any ideas on the best way to migrate over cleanly would also be welcome, the initialization process is slightly different so code changes will be needed in the web client.

@JustAMan
Copy link
Contributor

JustAMan commented Nov 27, 2019

This basically reverts parts of #520, ping @grafixeyehero

@dkanada
Copy link
Member

dkanada commented Nov 27, 2019

The logic looks fine though, we should always call the method here even if the auto-login option isn't checked.

@JustAMan
Copy link
Contributor

It does, but @grafixeyehero added that check for some reason (it was without this check before he made his PR), that's why I'm asking what was the reason for adding it.

@dkanada dkanada added the stable backport Backport into the next stable release label Nov 27, 2019
@grafixeyehero
Copy link
Contributor

this is my mistake thanks Wunax for fix

@dkanada dkanada merged commit ecabb4c into jellyfin:master Nov 28, 2019
@Wunax Wunax deleted the fix-connect-server-no-autologin branch November 29, 2019 10:08
@joshuaboniface joshuaboniface added this to Merged in Release 10.4.3 Dec 6, 2019
@joshuaboniface joshuaboniface removed the stable backport Backport into the next stable release label Dec 6, 2019
@joshuaboniface joshuaboniface removed this from Merged in Release 10.4.3 Dec 6, 2019
@joshuaboniface
Copy link
Member

File does not exist in 10.4.z release chain; not backporting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disabling Remember Me causes infinite Spinning Circle
5 participants