Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the page limit configurable #983

Merged
merged 18 commits into from
Apr 9, 2020
Merged

Conversation

heyhippari
Copy link
Contributor

Changes

I totally forgot I had this in progress, so here's a PR for it.

The setting is under Display, a value of 0 sets it to unlimited.

Issues

Fixes #279

image

@JustAMan
Copy link
Contributor

JustAMan commented Apr 3, 2020

@MrTimscampi what makes this a draft?

@heyhippari
Copy link
Contributor Author

@MrTimscampi what makes this a draft?

Not all views are covered. There's still a bunch of limits I need to change.

@heyhippari heyhippari marked this pull request as ready for review April 3, 2020 21:57
@heyhippari heyhippari requested a review from a team April 3, 2020 21:57
@heyhippari
Copy link
Contributor Author

This should be ready for review.

Can't find anymore views to edit. If I missed some, please report :)

src/controllers/movies/movietrailers.js Outdated Show resolved Hide resolved
src/controllers/music/songs.js Outdated Show resolved Hide resolved
src/controllers/shows/tvshows.js Outdated Show resolved Hide resolved
src/scripts/settings/userSettingsBuilder.js Outdated Show resolved Hide resolved
@dmitrylyzo
Copy link
Contributor

query.StartIndex -= query.Limit;

@dmitrylyzo
Copy link
Contributor

unused




@dmitrylyzo
Copy link
Contributor

With unlimited paging, on TV, with keyboard only - it will be a bit painful to get to the top menu from the very end of the library. :p

@heyhippari
Copy link
Contributor Author

With unlimited paging, on TV, with keyboard only - it will be a bit painful to get to the top menu from the very end of the library. :p

I think we should eventually have an horizontal layout for all of TV. Give its own UI and identity, tailor-made for remotes and TV, and not a weird hybrid of the desktop UI.

@dmitrylyzo dmitrylyzo added the merge conflict Conflicts prevent merging label Apr 9, 2020
@heyhippari heyhippari removed the merge conflict Conflicts prevent merging label Apr 9, 2020
@JustAMan JustAMan merged commit e58ce96 into jellyfin:master Apr 9, 2020
@poulpor
Copy link

poulpor commented Apr 14, 2020

Thank you very, very much MrTimscampi and others talented coders for adding this -long awaited- great new feature, it will make things far more easier for docker users like me and I hope it will be available in the next jellyfin release! For now, 10.5.4 is the best release I've used since the beginning of this incredible adventure, all the problems encountered while using previous ones are corrected, don't know if it's true but I have the feeling you've reached a point where you are now able to concentrate on new features and that's so exciting (who said lazy loading?)!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make pagination of libraries in the web UI optional/configurable
4 participants