Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign the downloads page to match the clients page design #85

Merged
merged 9 commits into from
Aug 17, 2022

Conversation

thornbill
Copy link
Member

Screenshot 2022-08-16 at 13-06-14 Downloads Jellyfin

@thornbill thornbill added the enhancement New feature or request label Aug 16, 2022
@nielsvanvelzen
Copy link
Member

Looks great overall, got some suggestions for the page (although they could be implemented in future PR's):

  • Show current platform by default (so a user using Windows sees the Windows tab when opening the page)
  • Add toggle for stable/unstable and only show instructions/downloads for that specific version (and ofc use stable by default)
  • Add the current version to the page, maybe even to the header so it's immediately clear what the latest (stable) version is when visiting the site
  • Make "docker" it's own tab, I believe it's popular enough to do so, I've seen other software do this too

@thornbill
Copy link
Member Author

  • Show current platform by default (so a user using Windows sees the Windows tab when opening the page)
    • I was planning to add this in a separate PR in the future
  • Add toggle for stable/unstable and only show instructions/downloads for that specific version (and ofc use stable by default)
    • It's not obvious in a single screenshot, but the instructions are hidden by default. When a user clicks a stable/unstable button it will either display the installation instructions or open the relevant link to the repo site.
  • Add the current version to the page, maybe even to the header so it's immediately clear what the latest (stable) version is when visiting the site
    • This is a great idea... I'll see what I can come up with for this.
  • Make "docker" it's own tab, I believe it's popular enough to do so, I've seen other software do this too
    • Good call... Currently the "Other" tab only includes docker and the dotnet portable build. I think I will rename it to "Docker" and include the portable build on the other tabs.

@nielsvanvelzen
Copy link
Member

  • Add toggle for stable/unstable and only show instructions/downloads for that specific version (and ofc use stable by default)
    • It's not obvious in a single screenshot, but the instructions are hidden by default. When a user clicks a stable/unstable button it will either display the installation instructions or open the relevant link to the repo site.

I think adding a single toggle (switch control on the right of the tabs maybe?) might still be better.

You don't need to repeat all the unstable buttons everywhere, and make it will be slightly harder to accidentally install unstable when you want stable (we have quite some users that aren't that technical and just press the very first button they see).

Take for example the .NET download site: https://dotnet.microsoft.com/en-us/download. You need to open the "all versions" list before you can attempt to download something different from a stable release.

@joshuaboniface
Copy link
Member

Show current platform by default (so a user using Windows sees the Windows tab when opening the page)

For the server page, I do not like this. It gives the false idea that an e.g. Windows client user "should" use the Windows server, which is not really a valid assumption. It also assumes the server would be installed on the machine doing the browsing, which is a little weird.

Add the current version to the page, maybe even to the header so it's immediately clear what the latest (stable) version is when visiting the site

If we can get this automatically from the releases page that's ideal. If it's manual updates hard no.

Make "docker" it's own tab, I believe it's popular enough to do so, I've seen other software do this too

Yes Docker is by far one of the most popular install types. It should be its own category high up (maybe just below Debuntu repo).

@thornbill
Copy link
Member Author

thornbill commented Aug 17, 2022

I agree that listing the current release should be automated... although I'm not sure what the best way to handle that is currently. We can definitely fetch the release info via the GH API, but it would probably be best to do that as part of a build/ci process.

Updated screenshot with feedback incorporated:
Screenshot 2022-08-17 at 03-00-50 Downloads Jellyfin

Copy link
Member

@nielsvanvelzen nielsvanvelzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it! 👍

@thornbill
Copy link
Member Author

thornbill commented Aug 17, 2022

Updated screenshot with pills for the stable/unstable selector instead of radio buttons:

Screenshot 2022-08-17 at 09-44-23 Downloads Jellyfin

@thornbill thornbill added this to the MVP milestone Aug 17, 2022
@thornbill thornbill merged commit 1e84086 into jellyfin:master Aug 17, 2022
@thornbill thornbill deleted the downloads-redux branch August 17, 2022 15:07
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants