-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Issue]: Auto Discovery listening address changed in unstable from 10.8.13 #11309
Comments
Hi, it seems like your issue report has the following item(s) that need to be addressed:
This is an automated message, currently under testing. Please file an issue here if you encounter any problems. |
In that PR, on Linux hosts, the auto-discovery will not bind to unicast addresses when IPv4 is enabled. This will cause the forwarding using unicast IP to break. You will want to broadcast in your k8s network and return the result. I don’t know the specific reason for this change but it looks intentional to me as there are at least three commits to make this behavior. |
cc @barronpm is this change intentional? |
This isn't ideal though, because then every pod in the cluster will see that traffic. It's a sensible and reasonable default behavior, however, so I don't think the change is bad. I'm hoping we can at least enable some way in which we can support a unicast address for auto discovery to not break this feature for anyone running in kubernetes. |
The change is intentional because otherwise we bind to the port on all interfaces and don't respect the bind IPs at all. |
Closing as the change is intentional. Feel free to drop by our forum or chat rooms to figure out a solution. https://jellyfin.org/contact |
…very See jellyfin/jellyfin#11309 for more details.
Please describe your bug
I recently moved from running 10.8.13 to unstable to get my AMD hardware acceleration working because I needed newer drivers. I run Jellyfin in kubernetes, and have some forwarding setup on my LAN to send the magic "Who is JellyfinServer?" packets to the service running in kubernetes on port 7359. This stopped working in unstable, and I suspect it's due to #10793 which looks to be far more restrictive in the addresses it binds to than the old code it replaced. This can be verified by running
lsof
:On 10.8.13,
lsof -nP -iUDP
shows these addresses and ports bound:On unstable,
lsof -nP -iUDP
shows these addresses and ports bound:I can run `tcpdump -i any -A 'port 7359' in both instances as well and see the UDP packet come into the Pod, but only see the response go out with 10.8.13.
Reproduction Steps
jellyfin/jellyfin:10.8.13
and define a Service with an IP so you can talk to it from a host machineecho -n 'Who is JellyfinServer?' | socat - udp-datagram:{service address}:7359,broadcast
jellyfin/jellyfin:unstable
and get no JSON responseJellyfin Version
Unstable (master branch)
if other:
No response
Environment
Jellyfin logs
FFmpeg logs
No response
Please attach any browser or client logs here
No response
Please attach any screenshots here
No response
Code of Conduct
The text was updated successfully, but these errors were encountered: