Auto Discovery Cleanup #10793
Merged
Auto Discovery Cleanup #10793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GetSmartApiUrl already returns PublishedServerUrl if set.
Shadowghost
approved these changes
Jan 1, 2024
|
This does not respect interface or bind address restrictions though, right? IMHO we should try to keep this functionality. |
Good point, I've updated the PR. |
JPVenson
reviewed
Jan 2, 2024
barronpm
force-pushed
the
autodiscovery-cleanup
branch
from
da20a6f
to
c8190af
Compare
crobibero
approved these changes
Jan 4, 2024
JPVenson
approved these changes
Jan 4, 2024
Bond-009
approved these changes
Jan 5, 2024
skysbird
pushed a commit
to skysbird/jellyfin
that referenced
this pull request
Feb 3, 2024
* Call GetSmartApiUrl directly in UdpServer.RespondToV2Message GetSmartApiUrl already returns PublishedServerUrl if set. * Rewrite auto discovery using UdpClient and BackgroundService * Respect network address settings in AutoDiscoveryHost * Always listen on broadcast address in Linux for auto-discovery * Await udp server tasks in AutoDiscoveryHost * Only bind to broadcast addresses for IPv4 * Only bind to broadcast if IPv4 is enabled
KrzaQ
pushed a commit
to KrzaQ/jellyfin
that referenced
this pull request
Feb 13, 2024
* Call GetSmartApiUrl directly in UdpServer.RespondToV2Message GetSmartApiUrl already returns PublishedServerUrl if set. * Rewrite auto discovery using UdpClient and BackgroundService * Respect network address settings in AutoDiscoveryHost * Always listen on broadcast address in Linux for auto-discovery * Await udp server tasks in AutoDiscoveryHost * Only bind to broadcast addresses for IPv4 * Only bind to broadcast if IPv4 is enabled
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Rewrites auto-discovery as a
BackgroundServiceusingUdpClient. Tested on Windows+Linux using broadcast and unicast.