Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.8.0 beta 2][Issue]: Error: Cannot get image dimensions on all .svg logos #7626

Closed
1 task done
srcrist opened this issue Apr 20, 2022 · 15 comments
Closed
1 task done
Labels
bug Something isn't working

Comments

@srcrist
Copy link

srcrist commented Apr 20, 2022

Please describe your bug

During scans, Jellyfin is sending numerous errors to the logs about not being able to determine the image dimensions for .svg logo files in the metadata. Manual investigation has shown that the files are not corrupt, and otherwise load correctly in a viewer.

Jellyfin Version

10.8.0

if other:

No response

Environment

- OS: Linux [Ubuntu 21.10]
- Virtualization: Bare Metal
- Clients: N/A
- Browser: N/A
- FFmpeg Version: Jellyfin-FFMPEG 4.4.1-4
- Playback Method: N/A
- Hardware Acceleration: N/A
- Plugins: AniDB, AudioDB, InfuseSync, Kodi Sync Queue, MusicBrainz, OMDb, Studio Images, TMDb, TVmaze, TheTVDB
- Reverse Proxy: nginx
- Base URL: none
- Networking: Direct 1gbps, Data Center
- Storage: local with cloud media

Jellyfin logs

[2022-04-19 21:58:08.375 -04:00] [ERR] Cannot get image dimensions for "/var/lib/jellyfin/metadata/library/88/88bf6d9eb317fed754379a5d9a1dd814/logo.svg"
Non-success codec result: Unimplemented
Jellyfin.Drawing.Skia.SkiaCodecException: Exception of type 'Jellyfin.Drawing.Skia.SkiaCodecException' was thrown.
   at Jellyfin.Drawing.Skia.SkiaEncoder.GetImageSize(String path)
   at Emby.Drawing.ImageProcessor.GetImageDimensions(BaseItem item, ItemImageInfo info)
   at Emby.Server.Implementations.Library.LibraryManager.UpdateImagesAsync(BaseItem item, Boolean forceUpdate)
[2022-04-19 21:58:30.253 -04:00] [ERR] Cannot get image dimensions for "/var/lib/jellyfin/metadata/library/b4/b4ad202466414ae545d97fedf72a898b/logo.svg"
Non-success codec result: Unimplemented
Jellyfin.Drawing.Skia.SkiaCodecException: Exception of type 'Jellyfin.Drawing.Skia.SkiaCodecException' was thrown.
   at Jellyfin.Drawing.Skia.SkiaEncoder.GetImageSize(String path)
   at Emby.Drawing.ImageProcessor.GetImageDimensions(BaseItem item, ItemImageInfo info)
   at Emby.Server.Implementations.Library.LibraryManager.UpdateImagesAsync(BaseItem item, Boolean forceUpdate)
[2022-04-19 21:58:47.527 -04:00] [ERR] Cannot get image dimensions for "/var/lib/jellyfin/metadata/library/7a/7a38914bb87174871eb4f707c95cfda0/logo.svg"
Non-success codec result: Unimplemented
Jellyfin.Drawing.Skia.SkiaCodecException: Exception of type 'Jellyfin.Drawing.Skia.SkiaCodecException' was thrown.
   at Jellyfin.Drawing.Skia.SkiaEncoder.GetImageSize(String path)
   at Emby.Drawing.ImageProcessor.GetImageDimensions(BaseItem item, ItemImageInfo info)
   at Emby.Server.Implementations.Library.LibraryManager.UpdateImagesAsync(BaseItem item, Boolean forceUpdate)
[2022-04-19 21:59:31.571 -04:00] [ERR] Cannot get image dimensions for "/var/lib/jellyfin/metadata/library/7e/7e64089fe9eea0edf3fe0e2cc7701365/logo.svg"
Non-success codec result: Unimplemented
Jellyfin.Drawing.Skia.SkiaCodecException: Exception of type 'Jellyfin.Drawing.Skia.SkiaCodecException' was thrown.
   at Jellyfin.Drawing.Skia.SkiaEncoder.GetImageSize(String path)
   at Emby.Drawing.ImageProcessor.GetImageDimensions(BaseItem item, ItemImageInfo info)
   at Emby.Server.Implementations.Library.LibraryManager.UpdateImagesAsync(BaseItem item, Boolean forceUpdate)
[2022-04-19 21:59:45.522 -04:00] [ERR] Cannot get image dimensions for "/var/lib/jellyfin/metadata/library/0c/0c3dd0e9e5216129e8e7746c213a5d39/logo.svg"
Non-success codec result: Unimplemented
Jellyfin.Drawing.Skia.SkiaCodecException: Exception of type 'Jellyfin.Drawing.Skia.SkiaCodecException' was thrown.
   at Jellyfin.Drawing.Skia.SkiaEncoder.GetImageSize(String path)
   at Emby.Drawing.ImageProcessor.GetImageDimensions(BaseItem item, ItemImageInfo info)
   at Emby.Server.Implementations.Library.LibraryManager.UpdateImagesAsync(BaseItem item, Boolean forceUpdate)
[2022-04-19 21:59:58.292 -04:00] [ERR] Cannot get image dimensions for "/var/lib/jellyfin/metadata/library/c1/c145024baf5e1baa4d2dbff5d0f46094/logo.svg"
Non-success codec result: Unimplemented
Jellyfin.Drawing.Skia.SkiaCodecException: Exception of type 'Jellyfin.Drawing.Skia.SkiaCodecException' was thrown.
   at Jellyfin.Drawing.Skia.SkiaEncoder.GetImageSize(String path)
   at Emby.Drawing.ImageProcessor.GetImageDimensions(BaseItem item, ItemImageInfo info)
   at Emby.Server.Implementations.Library.LibraryManager.UpdateImagesAsync(BaseItem item, Boolean forceUpdate)

FFmpeg logs

No response

Please attach any browser or client logs here

No response

Please attach any screenshots here

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@srcrist srcrist added the bug Something isn't working label Apr 20, 2022
@crobibero
Copy link
Member

Did this work in 10.7?

@jellyfin-bot jellyfin-bot added this to Needs triage in Issue Triage for Main Repo Apr 20, 2022
@srcrist
Copy link
Author

srcrist commented Apr 20, 2022

Did this work in 10.7?

I do not, unfortunately, have any logs remaining from 10.7 to check. I don't know, though.

@cvium
Copy link
Member

cvium commented Apr 20, 2022

I don't think skiasharp supports SVG. Dimensions for an SVG don't really make a lot of sense anyway?

@srcrist
Copy link
Author

srcrist commented Apr 20, 2022

That was my thought too, but I'm not familiar enough with the code and what it's doing here that I felt comfortable proffering that as a suggestion. My intuition was that this might just be a case where an exception needs to be crafted so it simply skips this step if the image format is SVG. Sounds like you're considering the same?

@dannymichel
Copy link

Did this work in 10.7?

I do not, unfortunately, have any logs remaining from 10.7 to check. I don't know, though.

this is a new bug. i only started getting it in 10.8. didn't exist in 10.7

@EVOTk
Copy link

EVOTk commented Jun 14, 2022

Same bug for me, new install of Jellyfin 10.8 in Docker ( Openmediavault 6 )

[19:16:45] [ERR] [21] Emby.Server.Implementations.Library.LibraryManager: Cannot get image dimensions for /config/data/metadata/library/07/0718f1a1bd500a3d22c57d8a84f47f9c/logo.svg
[19:16:45] [ERR] [32] Emby.Server.Implementations.Library.LibraryManager: Cannot get image dimensions for /config/data/metadata/library/39/3917bdbab69017623b0608e06ea5087a/logo.svg
[19:16:45] [ERR] [48] Emby.Server.Implementations.Library.LibraryManager: Cannot get image dimensions for /config/data/metadata/library/13/134ca9e32d3fdee88dc082823767f13a/logo.svg
[19:16:46] [ERR] [30] Emby.Server.Implementations.Library.LibraryManager: Cannot get image dimensions for /config/data/metadata/library/f1/f11dd1de6b165b050e1c9de1c3da6769/logo.svg
[19:16:46] [ERR] [30] Emby.Server.Implementations.Library.LibraryManager: Cannot get image dimensions for /config/data/metadata/library/08/08ed6b6748846f01383904fd1d21dd33/logo.svg
[19:16:46] [ERR] [30] Emby.Server.Implementations.Library.LibraryManager: Cannot get image dimensions for /config/data/metadata/library/b8/b89cc89b5d4dca75ee6720688912febd/logo.svg

@LePips
Copy link
Member

LePips commented Jun 16, 2022

Possibly related for svg logos which can't be handled: jellyfin/jellyfin-plugin-fanart#24

@cvium
Copy link
Member

cvium commented Jun 16, 2022

Where are the logos from?

@LePips
Copy link
Member

LePips commented Jun 16, 2022

I actually believe the logos we are seeing come from TMDb which was updated to support logo retrieval in 10.8.0.

#7219

@Avamander
Copy link

This error can cause large amounts of logspam, it would be nice if it could be at least trimmed down if it happens for SVG images.

@jellyfin-bot
Copy link
Contributor

This issue has gone 120 days without comment. To avoid abandoned issues, it will be closed in 21 days if there are no new comments.

If you're the original submitter of this issue, please comment confirming if this issue still affects you in the latest release or master branch, or close the issue if it has been fixed. If you're another user also affected by this bug, please comment confirming so. Either action will remove the stale label.

This bot exists to prevent issues from becoming stale and forgotten. Jellyfin is always moving forward, and bugs are often fixed as side effects of other changes. We therefore ask that bug report authors remain vigilant about their issues to ensure they are closed if fixed, or re-confirmed - perhaps with fresh logs or reproduction examples - regularly. If you have any questions you can reach us on Matrix or Social Media.

@jellyfin-bot jellyfin-bot added the stale Stale and will be closed if no activity occurs label Mar 23, 2023
JPVenson added a commit to JPVenson/jellyfin that referenced this issue Apr 1, 2023
@JPVenson
Copy link
Member

JPVenson commented Apr 1, 2023

Bump. Go away bot

JPVenson added a commit to JPVenson/jellyfin that referenced this issue Apr 1, 2023
@jellyfin-bot jellyfin-bot removed the stale Stale and will be closed if no activity occurs label Apr 2, 2023
@rgmz
Copy link

rgmz commented Apr 9, 2023

Considering that SkiaSharp.Svg is deprecated and hasn't had a release since 2018, would it make sense to use a different SVG-handling component?

@JPVenson
Copy link
Member

JPVenson commented Apr 9, 2023

Considering that SkiaSharp.Svg is deprecated and hasn't had a release since 2018, would it make sense to use a different SVG-handling component?

I am open for any recommendations

Bond-009 pushed a commit that referenced this issue Apr 10, 2023
#9581)

Co-authored-by: Shadowghost <Shadowghost@users.noreply.github.com>
@JPVenson
Copy link
Member

Issue should be mitigated by #9581

Issue Triage for Main Repo automation moved this from Needs triage to Closed/Done Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

No branches or pull requests