Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Album gain #10085

Merged
merged 6 commits into from
Aug 18, 2023
Merged

Album gain #10085

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
61a7c7e
Add LUFSAlbum DTO
TelepathicWalrus Aug 3, 2023
f2e4ad8
Get loudest track for smallest gain
TelepathicWalrus Aug 5, 2023
4d7918d
Move gain search to musicalbum
TelepathicWalrus Aug 5, 2023
81bb1a6
Use .Max for enumerable
TelepathicWalrus Aug 6, 2023
75e0f11
Update DTO to be consistent with other DTOs
TelepathicWalrus Aug 10, 2023
596d58b
Remove albumlufs,
TelepathicWalrus Aug 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion Emby.Server.Implementations/Dto/DtoService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -903,10 +903,11 @@ private void AttachBasicFields(BaseItemDto dto, BaseItem item, BaseItem owner, D
dto.IsPlaceHolder = supportsPlaceHolders.IsPlaceHolder;
}

dto.LUFS = item.LUFS;

// Add audio info
if (item is Audio audio)
{
dto.LUFS = audio.LUFS;
dto.Album = audio.Album;
if (audio.ExtraType.HasValue)
{
Expand Down
3 changes: 3 additions & 0 deletions MediaBrowser.Controller/Entities/Audio/MusicAlbum.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,9 @@ public async Task RefreshAllMetadata(MetadataRefreshOptions refreshOptions, IPro
progress.Report(percent * 95);
}

// get album LUFS
LUFS = items.OfType<Audio>().Max(item => item.LUFS);

var parentRefreshOptions = refreshOptions;
if (childUpdateType > ItemUpdateType.None)
{
Expand Down