-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for transcode audio file to PCM format #10321
Conversation
@feilongfl In which client have you tested this? |
I test audio both on linux and a MCU platform,Jellyfin is running in linux linuxI couldn't find a direct method to test PCM music on Linux, wget -O wget.pcm http://192.168.10.109:8096/Audio/84f7cdda408d432361c29d6bda9cbc27/universal?Container=pcm&TranscodingContainer=pcm&AudioCodec=pcm_s16le&audioBitRate=16000&api_key=d1e79804ea3b4215aecfc7d9a2043e23
ffmpeg -y -f s16le -ac 2 -ar 16000 -acodec pcm_s16le -i wget.pcm mp3.mp3
mplayer mp3.mp3 MCU platformI'm submitting this PR primarily for the following repository: It's in Chinese, but based on your github profile, I think you can understand it. Test Video Here: https://www.bilibili.com/video/BV1j94y1h7kn There are some noises on the MCU platform in video, There is no problem with the converted sound using ffmpeg on linux. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Since these PCM de/muxers have been around for over 10 years, I think it should be safe to just use them without checking.
Co-authored-by: Bond-009 <bond.009@outlook.com>
Support transcoding audio to PCM format; this allows the client to play directly through the I2S bus without decoding. This feature is particularly useful when playing with MCUs.
Changes
Add support for transcode audio file to PCM format