Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for transcode audio file to PCM format #10321

Merged
merged 3 commits into from
Oct 6, 2023
Merged

Add support for transcode audio file to PCM format #10321

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b83217d
use pcm as ext name when codec is pcm
feilongfl Oct 2, 2023
808e59f
add pcm format when codec is pcm_*
feilongfl Oct 2, 2023
33b3331
change Substring to AsSpan
feilongfl Oct 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions Jellyfin.Api/Helpers/StreamingHelpers.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,11 @@ public static class StreamingHelpers
state.OutputAudioBitrate = encodingHelper.GetAudioBitrateParam(streamingRequest.AudioBitRate, streamingRequest.AudioCodec, state.AudioStream, state.OutputAudioChannels) ?? 0;
}

if (outputAudioCodec.StartsWith("pcm_", StringComparison.Ordinal))
{
containerInternal = ".pcm";
}

state.OutputAudioCodec = outputAudioCodec;
state.OutputContainer = (containerInternal ?? string.Empty).TrimStart('.');
state.OutputAudioChannels = encodingHelper.GetNumAudioChannelsParam(state, state.AudioStream, state.OutputAudioCodec);
Expand Down
6 changes: 6 additions & 0 deletions MediaBrowser.Controller/MediaEncoding/EncodingHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6242,6 +6242,12 @@ public string GetProgressiveAudioFullCommandLine(EncodingJobInfo state, Encoding
audioTranscodeParams.Add("-acodec " + GetAudioEncoder(state));
}

if (GetAudioEncoder(state).StartsWith("pcm_", StringComparison.Ordinal))
{
audioTranscodeParams.Add(string.Concat("-f ", GetAudioEncoder(state).AsSpan(4)));
audioTranscodeParams.Add("-ar " + state.BaseRequest.AudioBitRate);
}

if (!string.Equals(outputCodec, "opus", StringComparison.OrdinalIgnoreCase))
{
// opus only supports specific sampling rates
Expand Down