Use eof_action=pass when overlaying subtitles
#10710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bond-009
approved these changes
Dec 12, 2023
nyanmisaka
requested changes
Dec 12, 2023
jkhsjdhjs
force-pushed
the
fix/subtitle_overlay_eof_action
branch
from
8252731
to
bcc376a
Compare
Good catch! I initially did the change on the |
JPVenson
added
enhancement
Found another one. Please remove the |
The previous behavior using `eof_action=endall` and `shortest=1` would end the video stream if one of the input stream (video, subtitle) ends. In some cases the duration of the overlayed subtitles is shorter than the video stream, causing the output to end when the subtitles end and dropping the remaining video stream. This commit changes this behavior so `eof_action=pass` is used instead, which continues passing the video stream through even if the subtitles end earlier [1]. `shortest=1` is also removed, as this option implies `eof_action=endall`. If the subtitle stream has a higher duration than the video stream, the output will also end with the video stream without `shortest=1`, as the video stream is the primary input to the `overlay` filter. Fix jellyfin#10698 [1] https://ffmpeg.org/ffmpeg-filters.html#Options-for-filters-with-several-inputs-_0028framesync_0029
jkhsjdhjs
force-pushed
the
fix/subtitle_overlay_eof_action
branch
from
bcc376a
to
547d97d
Compare
Done. I found two other occurances of the same line and removed the |
nyanmisaka
approved these changes
Dec 13, 2023
cvium
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous behavior using
eof_action=endallandshortest=1would end the video stream if one of the input stream (video, subtitle) ends. In some cases the duration of the overlayed subtitles is shorter than the video stream, causing the output to end when the subtitles end and dropping the remaining video stream.This commit changes this behavior so
eof_action=passis used instead, which continues passing the video stream through even if the subtitles end earlier [1].shortest=1is also removed, as this option implieseof_action=endall.If the subtitle stream has a higher duration than the video stream, the output will also end with the video stream without
shortest=1, as the video stream is the primary input to theoverlayfilter.Fix #10698
[1] https://ffmpeg.org/ffmpeg-filters.html#Options-for-filters-with-several-inputs-_0028framesync_0029