Fix FindExtras overwriting current extra type #11260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crobibero
approved these changes
Mar 30, 2024
Shadowghost
approved these changes
Mar 31, 2024
SourSulfur
pushed a commit
to SourSulfur/jellyfin
that referenced
this pull request
Apr 19, 2024
SourSulfur
pushed a commit
to SourSulfur/jellyfin
that referenced
this pull request
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The scanner will always overwrite all extras it found with new data. It doesn't really care about the existing database entry. In some cases this can change the type of an extra. This is a fix for that case by checking if the new type to set is not "unknown".
Changes
Issues