Remove SessionInfo.FullNowPlayingItem from API responses #11268
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I guess this is regression from when we moved over to ASP.NET. Seems to be available starting from our first OpenAPI schema.
There are two properties in SessionInfo:
The second one is the only place in the API that "exposes" BaseItem (the non-dto one). All other places use BaseItemDto. Fortunately, the property is nullable and an org-wide search shows none of our clients use FullNowPlayingItem. So removing it should not have any impact.
Changes
Issues
Partial fix for #11244, other exposed types like ClientCapabilities need a proper SessionInfoDto.