fix: av1 codecs string #11280
Merged
fix: av1 codecs string #11280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Browsers are very picky about this string. The profile level has to be padded to double digits otherwise the stream is going to be rejected and the playback would not continue. Signed-off-by: gnattu <gnattuoc@me.com>
Shadowghost
approved these changes
Apr 2, 2024
dmitrylyzo
reviewed
Apr 2, 2024
Co-authored-by: Dmitry Lyzo <56478732+dmitrylyzo@users.noreply.github.com>
JPVenson
reviewed
Apr 2, 2024
Bond-009
requested changes
Apr 2, 2024
nyanmisaka
approved these changes
Apr 2, 2024
There was a problem hiding this comment.
Good catch. The link in line 195 is outdated. Here’s the latest https://aomediacodec.github.io/av1-isobmff/#codecsparam
The level and bitdepth strings can be updated to use AppendFormat.
Signed-off-by: gnattu <gnattuoc@me.com>
Signed-off-by: gnattu <gnattuoc@me.com>
Bond-009
requested changes
Apr 2, 2024
Signed-off-by: gnattu <gnattuoc@me.com>
Bond-009
approved these changes
Apr 2, 2024
crobibero
approved these changes
Apr 2, 2024
SourSulfur
pushed a commit
to SourSulfur/jellyfin
that referenced
this pull request
Apr 19, 2024
Co-authored-by: Dmitry Lyzo <56478732+dmitrylyzo@users.noreply.github.com>
SourSulfur
pushed a commit
to SourSulfur/jellyfin
that referenced
this pull request
Apr 19, 2024
Co-authored-by: Dmitry Lyzo <56478732+dmitrylyzo@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Browsers are very picky about this string. The profile level has to be padded to double digits otherwise the stream is going to be rejected and the playback would not continue.
This is confirmed to work with latest Chromium 122 and Firefox 124, but Chromium used to be more picky about this string so additional hacks to lying about the level to it may be needed.
Issues
Fixes jellyfin/jellyfin-web#5364