Fix comparison for empty password migration #1264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bond-009
approved these changes
Apr 20, 2019
cvium
force-pushed
the
fix-empty-pw-migration
branch
from
a83c323
to
764c6d5
Compare
LogicalPhallacy
approved these changes
Apr 20, 2019
joshuaboniface
approved these changes
Apr 20, 2019
|
What does this mean for us that just migrated to 10.3.0? |
|
Hopefully it'll be fixed. |
|
I think I understand the changes now and what it means in practice is nothing, we're fine security wise :) I was freaking out a bit but it does not affect users/passwords |
|
Issue is still occurring with AndroidTV app. Tried resetting password and disabling easy pin option. Error received is Invalid User ID and/or Password. |
@xhaloz The Android TV app will likely need an update. Cc @thornbill |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Untested, but it should fix the empty pw migration issues