Fix markdown formatting / typo #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JustAMan
approved these changes
Dec 14, 2018
There was a problem hiding this comment.
Changes look good to me.
Please make a PR to develop branch next time as we've agreed that all commits should not go to master directly. Not sure if it was already properly fixed up in docs... @joshuaboniface, @anthonylavado, comments?
I've fixed this PR.
|
Sorry about that, but CONTRIBUTING.md states to make text/documentation changes against master. Am I understanding that incorrectly? |
|
I think we changed the agreement yesterday but nobody updated the file. I'll let others chime in to say whether I'm right about that change anyway. |
|
Oops! Yes, we didn’t update the docs yet to show that. Good catch! Will fix. |
nvllsvm
pushed a commit
that referenced
this pull request
Dec 27, 2018
Fix markdown formatting / typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.