Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add NuGet package info to plugin projects #486

Merged
merged 1 commit into from
Jan 8, 2019
Merged

Add NuGet package info to plugin projects #486

merged 1 commit into from
Jan 8, 2019

Conversation

Bond-009
Copy link
Member

@Bond-009 Bond-009 commented Jan 7, 2019 •
edited by joshuaboniface
Loading

This PR will add NuGet package info to the 3 projects needed by plugins.
These projects will get packaged with dotnet pack and uploaded to NuGet or Myget.

@Bond-009 Bond-009 changed the title [WIP] Ground work to get plugins functional again Ground work to get plugins functional again Jan 7, 2019
@Bond-009
Copy link
Member Author

Bond-009 commented Jan 7, 2019

The idea it that a maintainer would pack these up and upload them to NuGet.
dotnet cmd: dotnet pack example.csproj -c Release /p:Version=10.0.0

@hawken93
Copy link
Contributor

hawken93 commented Jan 7, 2019

Could that command be written in documentation? Such things are too easy to forget.. Another option is scripts/ directory or something. :) then a script could pack with the appropriate version and prepare for upload :)

@anthonylavado anthonylavado mentioned this pull request Jan 7, 2019
Closed
@joshuaboniface joshuaboniface changed the title Ground work to get plugins functional again Add NuGet package info to plugin projects Jan 8, 2019
joshuaboniface
joshuaboniface approved these changes Jan 8, 2019
View reviewed changes
Copy link
Member

@joshuaboniface joshuaboniface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as a solution-only change that will let plugin packagers get to work ASAP. 👍

JustAMan
JustAMan approved these changes Jan 8, 2019
View reviewed changes
Copy link
Contributor

@JustAMan JustAMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, though comment by @hawken93 makes a lot of sense to me.

@anthonylavado anthonylavado changed the base branch from master to dev January 8, 2019 21:50
@anthonylavado
Copy link
Member

Fixed base to Dev instead of Master.

@joshuaboniface joshuaboniface merged commit e406cd9 into jellyfin:dev Jan 8, 2019
@joshuaboniface joshuaboniface mentioned this pull request Jan 9, 2019
Merged
@Bond-009 Bond-009 deleted the plugins branch January 9, 2019 06:09
@JustAMan JustAMan mentioned this pull request Jan 11, 2019
Closed
@hawken93 hawken93 mentioned this pull request Jan 12, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustAMan JustAMan JustAMan approved these changes

@joshuaboniface joshuaboniface joshuaboniface approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Bond-009 @hawken93 @anthonylavado @JustAMan @joshuaboniface