Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't dispose managed CancellationTokenSource #6139

Merged
merged 4 commits into from
Jun 4, 2021
Merged

Don't dispose managed CancellationTokenSource #6139

merged 4 commits into from
Jun 4, 2021

Conversation

crobibero
Copy link
Member

@crobibero crobibero commented Jun 2, 2021 •
edited
Loading

Fixes an issue reported here.
Fixes #6141

@crobibero crobibero requested a review from Bond-009 June 2, 2021 02:59
@crobibero crobibero changed the title Don't dispose CTS, add comments Don't dispose managed CancellationTokenSource Jun 2, 2021
cvium
cvium approved these changes Jun 3, 2021
View reviewed changes
Copy link
Member

@cvium cvium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really like that we're accessing a disposed object but...

@Bond-009 Bond-009 merged commit 9154f20 into jellyfin:master Jun 4, 2021
@crobibero crobibero deleted the cts branch June 4, 2021 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cvium cvium cvium approved these changes

@Bond-009 Bond-009 Bond-009 approved these changes

@acvigue acvigue acvigue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Transcoding does not stop due to HTTP 500 error - latest master
4 participants
@crobibero @cvium @Bond-009 @acvigue