Refresh live TV channel image when remapped (issue #7834) #7843
+16
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jellyfin-bot
added
the
merge conflict
|
Is there a way I could patch my running Jellyfin installation to give this a try? |
|
@danielearwicker it would be appreciated if you can resolve the conflicts. |
Bond-009
removed
the
merge conflict
Shadowghost
approved these changes
Dec 18, 2023
1337joe
approved these changes
Dec 19, 2023
Bond-009
requested changes
Dec 19, 2023
JPVenson
approved these changes
Jan 2, 2024
|
This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged. |
jellyfin-bot
added
the
merge conflict
Bond-009
added a commit
to Bond-009/jellyfin
that referenced
this pull request
Mar 15, 2024
Bond-009
added a commit
to Bond-009/jellyfin
that referenced
this pull request
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
In
GetChannelAsynctheif (!item.HasImage(ImageType.Primary))check means once a channel has an image, it is never updated. So it continues to have the wrong image even after it has been manually remapped to the correct channel by the user.To know when the user has done this it seems like we need to store the URL that was fetched to save the local cached image for the channel. If the URL from the EPG is different from this, we should clear the primary image so it is refetched.
That's almost the whole change, except that probably to avoid doing a lot of unnecessary work the existing code in
UpdateImagesAsyncnever updates images for any live TV shows or channels. I've left that as it is except now it only applies to shows (of which there are huge numbers) but not channels (of which there are relatively few).Issues
Fixes #7834