Fix extra type differentiation #8638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change rules for Featurettes and Shorts so they don't both get classed as ExtraType.Clip. Fix test that these changes break
crobibero
approved these changes
Oct 28, 2022
cvium
approved these changes
Oct 28, 2022
|
Probably worth updating the docs to include "clips" in the list of folder types as well: |
1337joe
approved these changes
Oct 29, 2022
Bond-009
approved these changes
Oct 30, 2022
Closed
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change extra parsing rules for Featurettes and Shorts so they don't both get classed as ExtraType.Clip.
Fix test broken by these changes.
Changes
Change parsing rules for extras labeled "short" and "featurette." Both were previously classed as type "Clip"
Add two new Extra types (short, featurette)
Add parsing rule to allow "clip" extras in folder form. Now accommodates all supported extra types in either suffix or folder form.
Issues
Fixes #4114
Other
PR for user facing portion: 4115