Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Augment tag searching to consider individual ItemValues instead of the delimited tags field #8914

Merged
merged 1 commit into from
Jul 3, 2023

Conversation

bradbeattie
Copy link
Contributor

@bradbeattie bradbeattie commented Dec 15, 2022

Changes
This change improves tag searching. Previously, (Tags not null and Tags like @SearchTermContains) searched against the composed tag1|tag2|tag3 value. That approach had no good way of differentiating between str1 and prefix...str1...suffix which might have entirely different meaning (e.g. searching cia would turn up content from artifiCIAl intelligence).

This PR provides bias towards startswith and equals, additionally biasing content with multiple matching tags.

@bradbeattie bradbeattie changed the title Augment tag searching to consider all ItemValues Augment tag searching to consider individual ItemValues instead of the delimited tags field Dec 18, 2022
@github-actions
Copy link

Changes in OpenAPI specification found. Expand to see details.

What's New


GET /Images/General

Get all general images.

GET /Images/General/{name}/{type}

Get General Image.

GET /Images/MediaInfo

Get all media info images.

GET /Images/MediaInfo/{theme}/{name}

Get media info image.

GET /Images/Ratings

Get all general images.

GET /Images/Ratings/{theme}/{name}

Get rating image.

GET /Notifications/{userId}

Gets a user's notifications.

POST /Notifications/{userId}/Read

Sets notifications as read.

GET /Notifications/{userId}/Summary

Gets a user's notification summary.

POST /Notifications/{userId}/Unread

Sets notifications as unread.

POST /Notifications/Admin

Sends a notification to all admins.

What's Changed


POST /Users/{userId}/Authenticate
Parameters:

Added: password in query

The password sha1-hash.

POST /Users/AuthenticateByName
Request:

Changed content type : application/json

Updated AuthenticateUserByName :

  • Added property Password (string)

Gets or sets the sha1-hashed password.

Changed content type : text/json

Updated AuthenticateUserByName :

  • Added property Password (string)

Gets or sets the sha1-hashed password.

Changed content type : application/*+json

Updated AuthenticateUserByName :

  • Added property Password (string)

Gets or sets the sha1-hashed password.

@bradbeattie
Copy link
Contributor Author

Still relevant, I'd argue.

@bradbeattie
Copy link
Contributor Author

Thanks. Still need one more approval!

@cvium cvium merged commit 10fde0a into jellyfin:master Jul 3, 2023
@richlawson
Copy link

Sorry to raise a question in a merged PR, but this augmentation should also include genres, correct? Would this have needed to be restricted to where Type=4 to only include tags? Genres look like they're Type=2.

I'm looking at lines 3952 and 3937, noticing that the ItemValues specific to Tags and Genres have a where clause that includes that type.

I was looking into how to add genres to the search after reviewing #8842, and it looks like that work is already completed here with this further enhancement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants