-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Augment search to consider tags #8842
Conversation
Please make sure that excludedTags are respected and that the added clause does not clash with them. |
I wasn't aware of said functionality in Jellyfin! Checking... Yes, tested and confirmed things still work as expected. My proposed change only alters the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't tested it but code seems to be fine.
Would be nice if you can squash the commits. 3 commits for a one line change seem a bit much.
I'll squash them tonight when I'm at my home PC. Thanks! |
Okay, merge squashed. Back over to you! |
Considering bradbeattie/jellyfin@master...augmented-tag-searching as a second revision of this. I'll test it when I get a chance before submitting a PR. |
Ok, I'm a retard. How do I implement this? |
One method would be to use the unstable docker image, or wait until 10.9. |
Changes
This minor change permits users to search for items via tags.
Issues
Commentary
Seems to be a frequently requested feature. I considered searching with a join on the
ItemValues
table, but figured this direct approach would likely be sufficient.