Handle alternate case for worktreeconfig setting #1286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`extensions.worktreeconfig` was checked in a way that was not case-insensitive, but git config settings should be case insensitive. This behavior led to problems since the documentation describes the setting as `worktreeConfig` and GitHub Actions started setting the option with this casing. Fixes jelmer#1285
jelmer
approved these changes
Apr 22, 2024
|
Please take a look at the test failure. |
wshanks
commented
Apr 22, 2024
auto-merge was automatically disabled
April 22, 2024 23:29
Head branch was pushed to by a user without write access
jelmer
approved these changes
Apr 23, 2024
This was referenced Apr 23, 2024
0x2b3bfa0
added a commit
to 0x2b3bfa0/dulwich
that referenced
this pull request
Apr 23, 2024
renovate bot
added a commit
to Hapag-Lloyd/test
that referenced
this pull request
Apr 23, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [dulwich](https://togithub.com/dulwich/dulwich) | `==0.22.0` -> `==0.22.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>dulwich/dulwich (dulwich)</summary> ### [`v0.22.1`](https://togithub.com/jelmer/dulwich/releases/tag/dulwich-0.22.1): 0.22.1 [Compare Source](https://togithub.com/dulwich/dulwich/compare/dulwich-0.22.0...dulwich-0.22.1) #### What's Changed - Fix pypi deployments by [@​jelmer](https://togithub.com/jelmer) in [jelmer/dulwich#1284 - Handle alternate case for worktreeconfig setting by [@​wshanks](https://togithub.com/wshanks) in [jelmer/dulwich#1286 - Ship rust files. Fixes [#​1287](https://togithub.com/dulwich/dulwich/issues/1287) by [@​jelmer](https://togithub.com/jelmer) in [jelmer/dulwich#1290 #### New Contributors - [@​wshanks](https://togithub.com/wshanks) made their first contribution in [jelmer/dulwich#1286 **Full Changelog**: jelmer/dulwich@dulwich-0.22.0...dulwich-0.22.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/Hapag-Lloyd/test). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMTMuMSIsInVwZGF0ZWRJblZlciI6IjM3LjMxMy4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmN5Il19--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extensions.worktreeconfigwas checked in a way that was not case-insensitive, but git config settings should be case insensitive. This behavior led to problems since the documentation describes the setting asworktreeConfigand GitHub Actions started setting the option with this casing.Fixes #1285