Commit changes... #364
Merged
Commit changes... #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 16, 2017 05:22
* Add some .gitignore entries so we don't have loads of files to add if we are using gbp and debuild.
* Eliminate shellcheck warning.
* Check intltool is installed. Output message if not and then exit. * Eliminate shellcheck warning.
dev/find-dead-code.sh
Outdated
| @@ -3,7 +3,7 @@ | |||
| set -e | |||
|
|
|||
| cd "$(dirname "$0")" | |||
| cd .. | |||
| cd .. || exit | |||
There was a problem hiding this comment.
Why do we need || exit here and below? Would it be cleaner to not call the scripts in the first place?
There was a problem hiding this comment.
Issue will be rectified locally only.
* Reinstate code that emits warnings. I will suppress warnings locally.
|
Thanks! |
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
are using gbp and debuild.