Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Person.reader()/write() not following official GPX Schema. #38

Closed
Ernio3 opened this issue Nov 23, 2017 · 3 comments
Closed

Person.reader()/write() not following official GPX Schema. #38

Ernio3 opened this issue Nov 23, 2017 · 3 comments
Assignees
Labels
Milestone

Comments

@Ernio3
Copy link

Ernio3 commented Nov 23, 2017

While indeed Person reflects "personType" from official schema, it doesn't fit in Metadata which handles "personType" as "author".

<gpx creator="Creator" version="1.1">
  <metadata>
    <name>Name of GPX</name>
    <author>
      <name>Name of Author/Person</name>
      <link href="http://author.net">
        <text>Link of Author/Person</text>
      </link>
    </author>
    <link href="http://company.net">
      <text>Link of GPX</text>
    </link>
  </metadata>
</gpx>

Will produce:
gpx

Reason:
"author" tag is omitted making author's children be treated as "metadata".

Solution:
I think its enough to change: Person:187 and Person:199 from "person" to "author".

@jenetics jenetics self-assigned this Nov 23, 2017
@jenetics jenetics added the bug label Nov 23, 2017
@jenetics jenetics added this to the v1.2.1 milestone Nov 23, 2017
jenetics added a commit that referenced this issue Nov 23, 2017
@jenetics
Copy link
Owner

Thank you, @Ernio3. I could reproduce the bug and fixed it.

jenetics added a commit that referenced this issue Nov 23, 2017
@Ernio3
Copy link
Author

Ernio3 commented Nov 23, 2017

@jenetics If it's not a problem, I'd love to see 1.2.1 published to maven. Thank you for quick fix.

@jenetics
Copy link
Owner

It's already published to maven. http://search.maven.org/#artifactdetails%7Cio.jenetics%7Cjpx%7C1.2.1%7Cjar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants