fix(config.properties) reintroduce the APP_URL pattern
#159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hervelemeur
approved these changes
Oct 20, 2022
timja
reviewed
Oct 20, 2022
| @@ -18,7 +18,7 @@ recaptchaPublicKey=RECAPTCHA_PUBLIC_KEY | |||
| recaptchaPrivateKey=RECAPTCHA_PRIVATE_KEY | |||
|
|
|||
| # Optional: Default value set to http://accounts.jenkins.io/ | |||
| url=http://localhost:8080 | |||
| url=APP_URL | |||
There was a problem hiding this comment.
=/ great a file called example actually matters in production... iirc I had issues locally with it set to this but i'll look later
There was a problem hiding this comment.
yep, sorry I went for a quick rollback but we can definitvely improve this (like having the java app reading en vars instead of having an entrypoint.sh in the docker imag which "seds" the env vars 🥲
There was a problem hiding this comment.
right choice in the short term, for later: #162
This was referenced Oct 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #158