Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add contributors website CNAME records #173

Merged
merged 1 commit into from
Nov 22, 2023
Merged

feat: add contributors website CNAME records #173

merged 1 commit into from
Nov 22, 2023

Conversation

lemeurherve
Copy link
Member

This PR adds two CNAME records for the contributors website, one for serving the original content, the other for Fastly CDN.

Ref:

@lemeurherve lemeurherve requested a review from a team as a code owner November 22, 2023 10:25
smerle33
smerle33 approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@smerle33 smerle33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good :
Plan: 2 to add, 0 to change, 0 to destroy.

dduportal
dduportal approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lemeurherve lemeurherve merged commit f5506d0 into jenkins-infra:main Nov 22, 2023
7 checks passed
@lemeurherve lemeurherve deleted the helpdesk3809-add-contributors branch November 22, 2023 13:43
@lemeurherve lemeurherve mentioned this pull request Nov 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dduportal dduportal dduportal approved these changes

@smerle33 smerle33 smerle33 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lemeurherve @dduportal @smerle33